store: set auth headers when using login --with
Metadata
Current evaluation
Merged #3468 as b298e89d2, fixing Store authentication headers for credentials supplied through `snapcraft login --with`.
Resolution: closed resolved
Reason: PR #3468 was merged into master as commit b298e89d2. The change makes `snapcraft login --with` configure Store requests with the authentication headers from the supplied credentials.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3468 as b298e89d2, fixing Store authentication headers for credentials supplied through `snapcraft login --with`. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into master in #3468: store login --with now sets authentication headers. The change had two approvals and 100% diff coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master after two approvals and passing CI. Adds 29 lines and removes 8 across three files to set auth headers for login --with. Diff coverage is 100% with no overall coverage impact. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Sets authentication headers for the login --with command. Maintainer sergiusens submitted the change, which passed all checks with 100% diff coverage and zero impact on overall project coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3794 store: full support for legacy login | snapcraft | merged | Merged PR #3794 via commit 86193a7b4 (7194ef18d), restoring legacy-login compatibility by using existing Snapcraft credentials to build craft-store authorization headers. | |
| #3789 store: support login --with | snapcraft | merged | Merged PR #3789 restored LegacyUbuntuOne and legacy get_auth paths, adding backwards-compatible support for `snapcraft login --with`. |