← Back to issue list

store: full support for legacy login

View original Github issue

Metadata

Project
snapcraft
Number
#3794
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged into main. Implements legacy login support via craft-store authorization while preserving backwards compatibility with prior Snapcraft credentials. Approved, passed CI, and achieved 100% test coverage.

Suggested action:

No scores available.

Issue body

It uses craft-store's mechanisms to assemble the authorization header while still referencing the original login credentials from previous versions of Snapcraft. This is essentially full backwards compatibility. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main. Implements legacy login support via craft-store authorization while preserving backwards compatibility with prior Snapcraft credentials. Approved, passed CI, and achieved 100% test coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into main, implementing full legacy login support and backwards compatibility via craft-store authorization mechanisms while preserving original Snapcraft credentials. Code coverage increased by 0.05%.
qwen3.6-35b-a3b-mtp-q6 Merged into main, implementing full legacy login support using craft-store mechanisms while preserving backwards compatibility. The change achieved 100% diff coverage and increased overall test coverage by 0.05%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3789 store: support login --with snapcraft merged Merged into main. Implements login --with support by restoring the legacy LegacyUbuntuOne and get_auth code paths from snapcraft 6.1 for backwards compatibility. Approved by reviewer and passed CI checks.
80%
#3692 legacy storeapi: use craft-store snapcraft merged Merged PR replaces the legacy storeapi HTTP client with craft-store, removes obsolete tests and logout calls, and adapts the codebase to craft-store API changes. Approved and passed CI.
75%
#3797 store: export-login with legacy snapcraft merged Merged to main. Resolves export-login to stop prioritizing legacy credentials during export. Approved, passed CI, and maintained 100% coverage.
75%