store: full support for legacy login
Metadata
Current evaluation
Merged PR #3794 via commit 86193a7b4 (7194ef18d), restoring legacy-login compatibility by using existing Snapcraft credentials to build craft-store authorization headers.
Resolution: closed resolved
Reason: PR #3794 was merged into main as 86193a7b4, with implementation commit 7194ef18d. It added full backwards compatibility for legacy login credentials.
Evaluated by: mr-cal-bot
No scores available.
Issue body
It uses craft-store's mechanisms to assemble the authorization header
while still referencing the original login credentials from previous
versions of Snapcraft. This is essentially full backwards compatibility.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3794 via commit 86193a7b4 (7194ef18d), restoring legacy-login compatibility by using existing Snapcraft credentials to build craft-store authorization headers. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 7194ef18d, adding full legacy-login compatibility through craft-store authorization while reusing credentials from earlier Snapcraft versions. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3794 as 86193a7b4 (implementation 7194ef1), adding full legacy-login compatibility through craft-store authorization headers using existing Snapcraft credentials. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #3794 as commit 7194ef1, adding full legacy-login compatibility through craft-store authorization while reusing existing Snapcraft credentials. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Implements legacy login support via craft-store authorization while preserving backwards compatibility with prior Snapcraft credentials. Approved, passed CI, and achieved 100% test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main, implementing full legacy login support and backwards compatibility via craft-store authorization mechanisms while preserving original Snapcraft credentials. Code coverage increased by 0.05%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3789 store: support login --with | snapcraft | merged | Merged PR #3789 restored LegacyUbuntuOne and legacy get_auth paths, adding backwards-compatible support for `snapcraft login --with`. | |
| #3797 store: export-login with legacy | snapcraft | merged | Merged PR #3797 as commit fbc65bb38, ensuring legacy credentials do not take precedence when exporting a store login. | |
| #3692 legacy storeapi: use craft-store | snapcraft | merged | PR #3692 merged into snapcraft/7.0 (merge 5a850ca04, commit 15b55daa8), swapping legacy storeapi's http_clients implementation for craft-store, dropping obsolete tests, adapting callers to API changes, and removing needless logout calls. | |
| #3468 store: set auth headers when using login --with | snapcraft | merged | Merged #3468 as b298e89d2, fixing Store authentication headers for credentials supplied through `snapcraft login --with`. | |
| #3808 store: login requires no exported credentials | snapcraft | merged | Merged into main as commit 7e6ef4514, updating store login so it no longer requires exported credentials for CRAFT-1148. | |
| #1538657 Support uploading snaps to the store | snapcraft (launchpad) | closed | Added snapcraft upload for direct Store uploads in merged PR #197 (commit 23290980f), with authentication handled by existing login/logout commands. | |
| #3744 cli: enable craft-store logging | snapcraft | merged | Merged PR #3744 (commit 6f7e26e6a) enabled craft-store logging in the Snapcraft CLI; merge commit b5d3e916d. | |
| #3921 store: correctly logout when credentials are invalid for legacy | snapcraft | merged | Merged #3921 at da1766c, fixing logout by loading legacy credentials from the environment only when they are valid. | |
| #3684 legacy storeapi: use craft-store | snapcraft | closed | Closed in favor of #3692, which merged the legacy storeapi migration to craft-store as 15b55daa8 (merge 5a850ca04). | |
| #5536 fix(store): catch credential decoding errors | snapcraft | merged | Merged in canonical/snapcraft#5536 (commit 3784560f3), converting malformed store credential decoding failures into a user-friendly error and updating craft-store. |