store: support login --with
Metadata
Current evaluation
Merged PR #3789 restored LegacyUbuntuOne and legacy get_auth paths, adding backwards-compatible support for `snapcraft login --with`.
Resolution: closed resolved
Reason: PR #3789 was merged as commit 91dd56e33. It restored the LegacyUbuntuOne client and legacy get_auth flow, with tests, to support `login --with` compatibility.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is the simplest implementation for backwards compatibility.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1103
The new code here is LegacyUbuntuOne, the get_auth code path is brought back from legacy snapcraft (6.1) with the tests it had.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3789 restored LegacyUbuntuOne and legacy get_auth paths, adding backwards-compatible support for `snapcraft login --with`. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3789 (91dd56e) by sergiusens restored LegacyUbuntuOne and the legacy get_auth path in snapcraft/store/_legacy_account.py so `snapcraft login --with <file>` works again for backwards compatibility (CRAFT-1103). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3789 (91dd56e33), restoring LegacyUbuntuOne and legacy get_auth paths to support store login --with for backwards compatibility. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #3789 (87c72b2); store login gained --with support through restored legacy authentication paths for backward compatibility. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Implements login --with support by restoring the legacy LegacyUbuntuOne and get_auth code paths from snapcraft 6.1 for backwards compatibility. Approved by reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to main. Implemented backwards compatibility for login --with by reintroducing the LegacyUbuntuOne authentication code path and tests from snapcraft 6.1. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3794 store: full support for legacy login | snapcraft | merged | Merged PR #3794 via commit 86193a7b4 (7194ef18d), restoring legacy-login compatibility by using existing Snapcraft credentials to build craft-store authorization headers. | |
| #3468 store: set auth headers when using login --with | snapcraft | merged | Merged #3468 as b298e89d2, fixing Store authentication headers for credentials supplied through `snapcraft login --with`. |