← Back to issue list

store: support login --with

View original Github issue

Metadata

Project
snapcraft
Number
#3789
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main. Implements login --with support by restoring the legacy LegacyUbuntuOne and get_auth code paths from snapcraft 6.1 for backwards compatibility. Approved by reviewer and passed CI checks.

Suggested action: —

No scores available.

Issue body

This is the simplest implementation for backwards compatibility. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1103 The new code here is LegacyUbuntuOne, the get_auth code path is brought back from legacy snapcraft (6.1) with the tests it had.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into main. Implements login --with support by restoring the legacy LegacyUbuntuOne and get_auth code paths from snapcraft 6.1 for backwards compatibility. Approved by reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged to main. Implemented backwards compatibility for login --with by reintroducing the LegacyUbuntuOne authentication code path and tests from snapcraft 6.1.
qwen3.6-35b-a3b-mtp-q6 — — Merged to main. Added backwards-compatible login --with support by restoring the LegacyUbuntuOne class and get_auth code path from snapcraft 6.1, including corresponding unit tests. Resolves CRAFT-1103.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3794 store: full support for legacy login snapcraft merged Merged into main. Implements legacy login support via craft-store authorization while preserving backwards compatibility with prior Snapcraft credentials. Approved, passed CI, and achieved 100% test coverage.
80%
#3797 store: export-login with legacy snapcraft merged Merged to main. Resolves export-login to stop prioritizing legacy credentials during export. Approved, passed CI, and maintained 100% coverage.
70%