← Back to issue list

cli: introduce edit-validation-sets

View original Github issue

Metadata

Project
snapcraft
Number
#3512
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #3512 merged (commit 37dc52a13) adding the `edit-validation-sets` CLI command, modelled on edit-collaborators. The command shipped and was documented in release notes, later enhanced for components (#5059) and sequence warnings (#5535).

Resolution: closed resolved

Reason: Merged into snapcraft as commit 37dc52a13 ('cli: introduce edit-validation-sets (#3512)'), introducing StoreEditValidationSetsCommand in snapcraft/commands/validation_sets.py with --key-name/account-id/name/sequence args; it remains a shipped command and is announced in docs/release-notes/changelog.rst.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- This is roughly based on edit-collaborators

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3512 merged (commit 37dc52a13) adding the `edit-validation-sets` CLI command, modelled on edit-collaborators. The command shipped and was documented in release notes, later enhanced for components (#5059) and sequence warnings (#5535).
stealth/space-bunny-alpha — closed resolved Merged PR #3512, adding the edit-validation-sets CLI command and validation-set editing based on edit-collaborators.
qwen/qwen3.6-35b-a3b — — Merged the edit-validation-sets CLI command, enabling validation set editing. Based on the edit-collaborators implementation, the change received two approvals and added 322 lines across three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged cli: introduce edit-validation-sets. The change adds a new CLI command for editing validation sets, implemented similarly to edit-collaborators. The pull request was merged without additional comments or revisions.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3510 (confidence 80%)

    Companion PR 'cli: introduce list-validation-sets' (commit c9ce25fbd) adding the read side of the same feature.

  • Related To: canonical/snapcraft#3939 (confidence 75%)

    Follow-up PR moving edit-validation-sets to craft-cli emission (commit 786854900, CRAFT-1402).

  • Related To: canonical/snapcraft#5059 (confidence 65%)

    Later PR adding validation-set component support to edit-validation-sets (commit c9050163f).

Related issues

Issue Project State Summary Similarity
#3510 cli: introduce list-validation-sets snapcraft merged Merged into master as c9ce25fbd, introducing the list-validation-sets CLI command and unit tests.
74%
#3939 command: update edit-validation-sets to craft-cli snapcraft merged Merged as commit 786854900: PR #3939 moved edit-validation-sets from snapcraft_legacy to snapcraft using craft-cli emit output, Path-based edits, and a dedicated validation-sets command group (CRAFT-1402).
73%
#4918 Test validation-set commands snapcraft closed Added and merged spread tests for edit-validation-sets and list-validation-sets in PR #4924 (commit 157d0a182), resolving #4918.
71%
#3858 cli: fixup args to list-validation-sets snapcraft merged Merged #3858, fixing argument handling for the list-validation-sets CLI command in commit bf2c43c32.
70%