← Back to issue list

cli: introduce edit-validation-sets

View original Github issue

Metadata

Project
snapcraft
Number
#3512
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged the edit-validation-sets CLI command, enabling validation set editing. Based on the edit-collaborators implementation, the change received two approvals and added 322 lines across three files.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- This is roughly based on edit-collaborators

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the edit-validation-sets CLI command, enabling validation set editing. Based on the edit-collaborators implementation, the change received two approvals and added 322 lines across three files.
qwen3.6-35b-a3b-mtp-q6 Merged cli: introduce edit-validation-sets. The change adds a new CLI command for editing validation sets, implemented similarly to edit-collaborators. The pull request was merged without additional comments or revisions.
qwen3.6-35b-a3b-mtp-q6 Merged the edit-validation-sets CLI command, modeled after edit-collaborators. The change introduces a new interface for managing validation sets directly into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3510 cli: introduce list-validation-sets snapcraft merged Merged into master after approval by two reviewers and passing CI checks. Introduces a new list-validation-sets CLI command, adding 199 lines across two files with 100% diff coverage.
80%
#3858 cli: fixup args to list-validation-sets snapcraft merged Merged after maintainer approval. The change fixes CLI argument handling for the list-validation-sets command, updating two files with 31 additions and one deletion. No unresolved review comments were present.
78%
#3939 command: update edit-validation-sets to craft-cli snapcraft merged Merged migration of edit-validation-sets to craft-cli. Replaces click with emit for output, refactors file editing to use Path, updates tests, and separates validation sets into a dedicated command group. Approved and merged.
75%
#3942 commands: allow re-editing validation sets on error snapcraft merged Merged. Allows re-editing validation sets after rejection by extracting helper methods and adding a re-edit prompt loop. Approved by two reviewers with passing CI checks.
74%