← Back to issue list

Test validation-set commands

View original Github issue

Metadata

Project
snapcraft
Number
#4918
Type
issue
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Added and merged spread tests for edit-validation-sets and list-validation-sets in PR #4924 (commit 157d0a182), resolving #4918.

Resolution: closed resolved

Reason: PR #4924 was merged with spread-test coverage for both validation-set commands; commit 157d0a182 records the change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Test `edit-validation-sets` and `list-validation-sets` ### Why it needs to get done To test our code and prevent issues like #4909

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Added and merged spread tests for edit-validation-sets and list-validation-sets in PR #4924 (commit 157d0a182), resolving #4918.
stealth/space-bunny-alpha — closed resolved Added Spread coverage for edit-validation-sets and list-validation-sets in merged PR #4924 (commit 157d0a182), resolving the missing command tests.
stealth/space-bunny-alpha — closed resolved Added spread tests for edit-validation-sets and list-validation-sets; merged in PR #4924 (commit 157d0a182), resolving #4918.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The request to add tests for edit-validation-sets and list-validation-sets commands was never addressed. A Jira ticket was created for tracking, but no tests were written or merged.
qwen/qwen3.6-35b-a3b — — Testing validation-set commands was never implemented. The issue was closed with only a bot comment syncing the task to an internal Jira ticket, indicating the work was deferred or abandoned.
qwen/qwen3.6-35b-a3b — — Closed without implementation. No tests for edit-validation-sets and list-validation-sets were added or merged. The request remains unresolved.
qwen3.6-35b-a3b-mtp-q6 — — Closed and abandoned without implementation. No tests were added for the validation-set commands, leaving the request unaddressed.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#4924 tests: add spread tests for validation-sets snapcraft merged Merged PR #4924 added spread coverage for edit-validation-sets and list-validation-sets, closing #4918; merge commit 157d0a182.
88%
#5075 tests: fix validation sets spread test snapcraft merged Merged PR #5075 (commit a22b218ab) fixed #5053 by making the validation-sets spread test use hello-world and check presence instead of a fixed revision.
79%
#5053 Fix validation-sets spread test snapcraft closed Fixed validation-sets spread-test coverage in commit a22b218ab after staging-store cleanup removed the required test snap.
74%
#3942 commands: allow re-editing validation sets on error snapcraft merged Merged PR #3942 (commit e615f7a27) lets users re-edit rejected validation sets and refactors validation-set generation and submission helpers.
72%
#3512 cli: introduce edit-validation-sets snapcraft merged PR #3512 merged (commit 37dc52a13) adding the `edit-validation-sets` CLI command, modelled on edit-collaborators. The command shipped and was documented in release notes, later enhanced for components (#5059) and sequence warnings (#5535).
71%
#3510 cli: introduce list-validation-sets snapcraft merged Merged into master as c9ce25fbd, introducing the list-validation-sets CLI command and unit tests.
71%
#6423 fix(validation-sets): don't validate new sets snapcraft closed PR #6423 (SNAPCRAFT-1379) fixed edit-validation-sets rejecting brand-new validation sets at sequence 1; approved with no unresolved comments and landed as commit e7b47adb7, stacking on merged PR #6420.
71%
#3858 cli: fixup args to list-validation-sets snapcraft merged Merged #3858, fixing argument handling for the list-validation-sets CLI command in commit bf2c43c32.
71%