command: update edit-validation-sets to craft-cli
Metadata
Current evaluation
Merged migration of edit-validation-sets to craft-cli. Replaces click with emit for output, refactors file editing to use Path, updates tests, and separates validation sets into a dedicated command group. Approved and merged.
Suggested action: —
No scores available.
Issue body
This is a minimal code change migration from Snapcraft's snapcraft_legacy module to snapcraft. Adaptations to use craft-cli for output has been made, as well as updates to how file edit takes place by migrating it to use Path.
The tests have been updated to follow the newer conventions of the code base, but the gist of them has not changed at all.
Lastly, the only UI change is that validation sets have been separated into their own command group.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1402
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged migration of edit-validation-sets to craft-cli. Replaces click with emit for output, refactors file editing to use Path, updates tests, and separates validation sets into a dedicated command group. Approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged migration of the edit-validation-sets command from snapcraft_legacy to snapcraft. Replaced click with craft-cli emit, updated file handling to Path, and separated validation sets into a dedicated command group. Tests updated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged migration of edit-validation-sets to snapcraft, replacing click with craft-cli emit and updating file handling to Path. Validation sets now use a dedicated command group. Approved after author clarified material changes. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3512 cli: introduce edit-validation-sets | snapcraft | merged | Merged the edit-validation-sets CLI command, enabling validation set editing. Based on the edit-collaborators implementation, the change received two approvals and added 322 lines across three files. | |
| #5007 refactor(application): commands, pre-run validation | snapcraft | merged | Merged after approval and CI. Refactored command handling and pre-run validation using craft-cli groups. Improved error formatting, targeted SNAPCRAFT_REMOTE_BUILD_STRATEGY validation, and fixed core20/core24 compatibility. Resolves #4911 and #5008. | |
| #29 tests: use the Craft CLI lib fixtures | rockcraft | merged | Merged updates to replace test fixtures with the Craft CLI library version. Approved by one reviewer, modifying five files (+11/-54 lines). Resolves CRAFT-996. |