← Back to issue list

command: update edit-validation-sets to craft-cli

View original Github issue

Metadata

Project
snapcraft
Number
#3939
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 786854900: PR #3939 moved edit-validation-sets from snapcraft_legacy to snapcraft using craft-cli emit output, Path-based edits, and a dedicated validation-sets command group (CRAFT-1402).

Resolution: closed resolved

Reason: The PR was approved and merged into snapcraft as commit 786854900 (CRAFT-1402), with tigarmo's review comments resolved after sergiusens annotated the substantive changes (click→emit, pydantic/Path edits). The command now lives in snapcraft/commands/validation_sets.py with its own command group.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This is a minimal code change migration from Snapcraft's snapcraft_legacy module to snapcraft. Adaptations to use craft-cli for output has been made, as well as updates to how file edit takes place by migrating it to use Path. The tests have been updated to follow the newer conventions of the code base, but the gist of them has not changed at all. Lastly, the only UI change is that validation sets have been separated into their own command group. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- CRAFT-1402

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 786854900: PR #3939 moved edit-validation-sets from snapcraft_legacy to snapcraft using craft-cli emit output, Path-based edits, and a dedicated validation-sets command group (CRAFT-1402).
stealth/space-bunny-alpha — closed resolved Merged PR #3939 (commit 786854900, CRAFT-1402): migrated edit-validation-sets from snapcraft_legacy to snapcraft using craft-cli emit output and pathlib edits, splitting validation sets into their own command group.
stealth/space-bunny-alpha — closed resolved Merged PR #3939 (commit 786854900), migrating edit-validation-sets from snapcraft_legacy to snapcraft, using craft-cli output, Path-based edits, and a dedicated validation-sets command group.
stealth/space-bunny-alpha — closed resolved Merged #3939 (commit 786854900): migrated edit-validation-sets from snapcraft_legacy to snapcraft and craft-cli, using emit and Path-based file editing.
qwen/qwen3.6-35b-a3b — — Merged migration of edit-validation-sets to craft-cli. Replaces click with emit for output, refactors file editing to use Path, updates tests, and separates validation sets into a dedicated command group. Approved and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged migration of the edit-validation-sets command from snapcraft_legacy to snapcraft. Replaced click with craft-cli emit, updated file handling to Path, and separated validation sets into a dedicated command group. Tests updated.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3512 (confidence 85%)

    Earlier merged PR that introduced the edit-validation-sets command that this PR migrates off snapcraft_legacy.

  • Related To: canonical/snapcraft#6420 (confidence 55%)

    Later fix (2989b5f8b) in the same validation-sets command area, showing the migrated code path continued to receive fixes.

Related issues

Issue Project State Summary Similarity
#3512 cli: introduce edit-validation-sets snapcraft merged PR #3512 merged (commit 37dc52a13) adding the `edit-validation-sets` CLI command, modelled on edit-collaborators. The command shipped and was documented in release notes, later enhanced for components (#5059) and sequence warnings (#5535).
73%
#6423 fix(validation-sets): don't validate new sets snapcraft closed PR #6423 (SNAPCRAFT-1379) fixed edit-validation-sets rejecting brand-new validation sets at sequence 1; approved with no unresolved comments and landed as commit e7b47adb7, stacking on merged PR #6420.
71%