autotools v1 plugin: set correct file permissions for scripts (CRAFT-666)
Metadata
Current evaluation
Merged fix for the autotools v1 plugin correcting file permissions on autogen.sh and bootstrap scripts when they lack executable flags. Code was simplified. Approved by one reviewer and passed CI checks.
Suggested action: —
No scores available.
Issue body
The autogen.sh and bootstrap scripts had overeager permissions set
when they were found not to be executable.
The code has also been simplified.
LP: #1951645
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
-------
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for the autotools v1 plugin correcting file permissions on autogen.sh and bootstrap scripts when they lack executable flags. Code was simplified. Approved by one reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Corrected file permissions for autogen.sh and bootstrap scripts in the autotools v1 plugin to ensure proper executable status. Code was simplified. Passed unit tests with 90% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, correcting file permissions for autogen.sh and bootstrap scripts in the autotools v1 plugin when they were not executable. Code was simplified. Passed static and unit tests with 90% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3398 autotools v2 plugin: support autogen.sh and bootstrap | snapcraft | merged | Merged into master. Adds autogen.sh and bootstrap script support to the autotools v2 plugin. Approved by reviewer, passed CI, and maintained coverage. | |
| #3628 Autotools Plugin (v1): Fix fatal crash when running autogen.sh or bootstrap | snapcraft | merged | Merged a fix for the Autotools Plugin v1 that resolved a fatal crash when running autogen.sh or bootstrap scripts. Path objects were converted to strings before shlex processing to prevent a TypeError. Approved and merged, though excluded from the v6.1 release. | |
| #3694 autotools v1 plugin: fix fatal crash when running autogen.sh or bootstrap | snapcraft | closed | Superseded by pull request #3739. The autotools v1 plugin crash fix was closed without merging after three weeks of review inactivity. | |
| #533 autotools plugin: support bootstrap parameters | craft-parts | merged | Merged after approval by two reviewers, adding bootstrap parameter support to the autotools plugin. The update modifies four files with 109 additions and 3 deletions, extending build configuration capabilities. | |
| #208 Backport to 1.x: Autotools plugin: Set autogen.sh executable. | snapcraft | merged | Merged backport of #206 to the 1.x branch. The change sets autogen.sh as executable in the Autotools plugin, updating two files with 174 additions and one deletion. | |
| #1076 autotools: extend Make plugin instead of repeating code | snapcraft | merged | Merged into master. Refactored the autotools plugin to extend the existing Make plugin, eliminating duplicated build logic. Approved by one reviewer, passed CI checks, and reduced code by 19 lines across four files. | |
| #35 plugins: add autotools plugin | craft-parts | merged | Merged the addition of an autotools plugin for handling ./configure scripts. Approved by two reviewers, the change adds 195 lines across four files, successfully integrating new build system support. | |
| #206 Autotools plugin: Set autogen.sh executable. | snapcraft | merged | Merged. Fixes Launchpad bug #1530995 by ensuring autogen.sh is executable and adds corresponding tests. Approved by sergiusens after commit message formatting adjustments. |