autotools v1 plugin: set correct file permissions for scripts (CRAFT-666)
Metadata
Current evaluation
Merged PR #3601 in commit 43eb836d8, fixing Autotools v1 permissions for non-executable autogen.sh and bootstrap scripts and simplifying the implementation.
Resolution: closed resolved
Reason: PR #3601 was merged into master as commit 43eb836d8. It corrected the file-permission handling for autogen.sh and bootstrap scripts and simplified the code.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The autogen.sh and bootstrap scripts had overeager permissions set
when they were found not to be executable.
The code has also been simplified.
LP: #1951645
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
-------
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3601 in commit 43eb836d8, fixing Autotools v1 permissions for non-executable autogen.sh and bootstrap scripts and simplifying the implementation. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3601 (43eb836d8) fixed autotools v1 handling of non-executable autogen.sh/bootstrap scripts and simplified the code for CRAFT-666. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for the autotools v1 plugin correcting file permissions on autogen.sh and bootstrap scripts when they lack executable flags. Code was simplified. Approved by one reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Corrected file permissions for autogen.sh and bootstrap scripts in the autotools v1 plugin to ensure proper executable status. Code was simplified. Passed unit tests with 90% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #206 Autotools plugin: Set autogen.sh executable. | snapcraft | merged | Merged PR #206 fixed LP #1530995 by making autogen.sh executable when needed and adding Autotools plugin tests (commit 85405240f). | |
| #1951645 chmod 777 in autotools plugin | snapcraft (launchpad) | closed | Fixed in snapcore/snapcraft#3601 (commit 08a347754), replacing the autotools v1 plugin's overly broad permissions with correct permissions for scripts. | |
| #3398 autotools v2 plugin: support autogen.sh and bootstrap | snapcraft | merged | Merged into master in commit 3fabd01b9, adding autogen.sh and bootstrap script support to the autotools v2 plugin. | |
| #3694 autotools v1 plugin: fix fatal crash when running autogen.sh or bootstrap | snapcraft | closed | Closed unmerged as superseded by snapcraft#3739, which merged the broader legacy-plugin Path-to-string fix in commit e4725e466. | |
| #3628 Autotools Plugin (v1): Fix fatal crash when running autogen.sh or bootstrap | snapcraft | merged | Merged in commit 8e2cf1a25, converting autogen.sh and bootstrap Path values to strings before shlex quoting. Follow-up #3739 generalized the legacy-plugin fix. | |
| #208 Backport to 1.x: Autotools plugin: Set autogen.sh executable. | snapcraft | merged | Merged into 1.x: PR #208 backported #206, making the Autotools plugin set autogen.sh executable and adding tests. | |
| #533 autotools plugin: support bootstrap parameters | craft-parts | merged | Merged PR #533 in commit 45cbc684, adding autotools-bootstrap-parameters so the plugin can pass flags to ./bootstrap when generating configure. | |
| #1621700 autotools plugin failed with env: ‘./bootstrap’: Permission denied | snapcraft (launchpad) | closed | Autotools now ignores a bootstrap directory instead of executing it, fixing the permission-denied failure in canonical/snapcraft#803 via commit eee1b84dd. | |
| #1882425 autotools plugin should still honour autogen.sh if present | snapcraft (launchpad) | closed | Autotools v2 gained autogen.sh/bootstrap fallback support in canonical/snapcraft#3398, merged as 3fabd01b9 and released before the issue was closed. | |
| #35 plugins: add autotools plugin | craft-parts | merged | Merged PR #35, adding an Autotools plugin for parts built through the ./configure script; implementation 54b124c8, merge commit 6140b8e6. |