← Back to issue list

Autotools plugin: Set autogen.sh executable.

View original Github issue

Metadata

Project
snapcraft
Number
#206
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #206 fixed LP #1530995 by making autogen.sh executable when needed and adding Autotools plugin tests (commit 85405240f).

Resolution: closed resolved

Reason: PR #206 was merged in commit 209a587d7. Its fix, commit 85405240f, corrected autogen.sh permissions and added plugin tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR fixes LP: [#1530995](https://bugs.launchpad.net/snapcraft/+bug/1530995) by setting autogen.sh to be executable (if necessary). It also adds tests for the autotools plugin. It will need to be backported to 1.x when approved.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #206 fixed LP #1530995 by making autogen.sh executable when needed and adding Autotools plugin tests (commit 85405240f).
stealth/space-bunny-alpha — closed resolved Merged PR #206 fixed LP #1530995 by making autogen.sh executable when needed and adding Autotools plugin tests (commit 85405240f).
qwen/qwen3.6-35b-a3b — — Merged. Fixes Launchpad bug #1530995 by ensuring autogen.sh is executable and adds corresponding tests. Approved by sergiusens after commit message formatting adjustments.
qwen3.6-35b-a3b-mtp-q6 — — Merged after review. Fixed Launchpad bug #1530995 by ensuring autogen.sh is executable in the autotools plugin and added tests. Requires backporting to the 1.x branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#208 Backport to 1.x: Autotools plugin: Set autogen.sh executable. snapcraft merged Merged into 1.x: PR #208 backported #206, making the Autotools plugin set autogen.sh executable and adding tests.
83%
#3628 Autotools Plugin (v1): Fix fatal crash when running autogen.sh or bootstrap snapcraft merged Merged in commit 8e2cf1a25, converting autogen.sh and bootstrap Path values to strings before shlex quoting. Follow-up #3739 generalized the legacy-plugin fix.
77%
#3601 autotools v1 plugin: set correct file permissions for scripts (CRAFT-666) snapcraft merged Merged PR #3601 in commit 43eb836d8, fixing Autotools v1 permissions for non-executable autogen.sh and bootstrap scripts and simplifying the implementation.
76%
#3398 autotools v2 plugin: support autogen.sh and bootstrap snapcraft merged Merged into master in commit 3fabd01b9, adding autogen.sh and bootstrap script support to the autotools v2 plugin.
76%
#1882425 autotools plugin should still honour autogen.sh if present snapcraft (launchpad) closed Autotools v2 gained autogen.sh/bootstrap fallback support in canonical/snapcraft#3398, merged as 3fabd01b9 and released before the issue was closed.
74%
#35 plugins: add autotools plugin craft-parts merged Merged PR #35, adding an Autotools plugin for parts built through the ./configure script; implementation 54b124c8, merge commit 6140b8e6.
74%
#1507648 Autotools doesn't work without autogen.sh snapcraft (launchpad) closed Added an autoreconf-based Autotools option in commit 9d9a357b7 and released it in Snapcraft 0.4; later #3398 added autogen.sh/bootstrap support to v2.
72%
#3694 autotools v1 plugin: fix fatal crash when running autogen.sh or bootstrap snapcraft closed Closed unmerged as superseded by snapcraft#3739, which merged the broader legacy-plugin Path-to-string fix in commit e4725e466.
72%
#11 Autotools doesn't work without autogen.sh snapcraft closed Closed without implementation after a maintainer said it lacked a test; later Autotools v2 gained autoreconf fallback support in PR #3398 (commit 3fabd01b9).
71%
#1076 autotools: extend Make plugin instead of repeating code snapcraft merged Merged into master: Autotools was changed to extend the Make plugin and reuse its build flow instead of duplicating logic (commit 83072a5b2).
71%