← Back to issue list

autotools v1 plugin: fix fatal crash when running autogen.sh or bootstrap

View original Github issue

Metadata

Project
snapcraft
Number
#3694
Type
pull request
State
closed
Author
mtmiller
Labels
Created
Updated
Closed

Current evaluation

Superseded by pull request #3739. The autotools v1 plugin crash fix was closed without merging after three weeks of review inactivity.

Suggested action:

No scores available.

Issue body

Adapt the fix applied in 916965432b37f30e480fee50a019bc4ab4f91970 to the autotools v1 plugin. Signed-off-by: Mike Miller <mtmiller@debian.org> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Superseded by pull request #3739. The autotools v1 plugin crash fix was closed without merging after three weeks of review inactivity.
qwen3.6-35b-a3b-mtp-q6 Fixes a fatal crash in the autotools v1 plugin during autogen.sh or bootstrap. Closed without merging and superseded by pull request #3739 after three weeks of inactivity awaiting review.
qwen3.6-35b-a3b-mtp-q6 Superseded by pull request #3739 after three weeks without review. The change aimed to fix a fatal crash in the autotools v1 plugin during autogen.sh or bootstrap but was not merged directly.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3628 Autotools Plugin (v1): Fix fatal crash when running autogen.sh or bootstrap snapcraft merged Merged a fix for the Autotools Plugin v1 that resolved a fatal crash when running autogen.sh or bootstrap scripts. Path objects were converted to strings before shlex processing to prevent a TypeError. Approved and merged, though excluded from the v6.1 release.
83%
#3398 autotools v2 plugin: support autogen.sh and bootstrap snapcraft merged Merged into master. Adds autogen.sh and bootstrap script support to the autotools v2 plugin. Approved by reviewer, passed CI, and maintained coverage.
78%
#3601 autotools v1 plugin: set correct file permissions for scripts (CRAFT-666) snapcraft merged Merged fix for the autotools v1 plugin correcting file permissions on autogen.sh and bootstrap scripts when they lack executable flags. Code was simplified. Approved by one reviewer and passed CI checks.
75%
#1882425 autotools plugin should still honour autogen.sh if present snapcraft (launchpad) closed Abandoned. The request for the autotools plugin v2 to preserve autogen.sh execution was closed without resolution, leaving the plugin to skip autogen.sh and run autoreconf directly.
74%
#1018 autotools: extend Make plugin instead of repeating code snapcraft closed Closed due to inactivity after a reviewer requested a bug report and changes. The author responded and added the bug, but a force-push prevented reopening. The reviewer instructed the author to re-propose the pull request.
74%
#533 autotools plugin: support bootstrap parameters craft-parts merged Merged after approval by two reviewers, adding bootstrap parameter support to the autotools plugin. The update modifies four files with 109 additions and 3 deletions, extending build configuration capabilities.
74%
#1661424 autotools plugin crashes while running ./configure snapcraft (launchpad) closed Closed without resolution or comments. The autotools plugin crash during ./configure due to a missing Python interpreter was not fixed and appears abandoned.
72%
#208 Backport to 1.x: Autotools plugin: Set autogen.sh executable. snapcraft merged Merged backport of #206 to the 1.x branch. The change sets autogen.sh as executable in the Autotools plugin, updating two files with 174 additions and one deletion.
72%
#1076 autotools: extend Make plugin instead of repeating code snapcraft merged Merged into master. Refactored the autotools plugin to extend the existing Make plugin, eliminating duplicated build logic. Approved by one reviewer, passed CI checks, and reduced code by 19 lines across four files.
72%
#35 plugins: add autotools plugin craft-parts merged Merged the addition of an autotools plugin for handling ./configure scripts. Approved by two reviewers, the change adds 195 lines across four files, successfully integrating new build system support.
71%