autotools v1 plugin: fix fatal crash when running autogen.sh or bootstrap
Metadata
Current evaluation
Closed unmerged as superseded by snapcraft#3739, which merged the broader legacy-plugin Path-to-string fix in commit e4725e466.
Resolution: closed superseded
Reason: The author closed it after three weeks without review, noting that #3739 superseded it. That PR implemented the broader fix in 13702bf1c and merged as e4725e466.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Adapt the fix applied in 916965432b37f30e480fee50a019bc4ab4f91970 to the autotools v1 plugin.
Signed-off-by: Mike Miller <mtmiller@debian.org>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as superseded by snapcraft#3739, which merged the broader legacy-plugin Path-to-string fix in commit e4725e466. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as superseded by #3739, which delivered a broader fix converting legacy plugin command paths to strings. The replacement merged as e4725e466 (implementation 13702bf1c). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as superseded by #3739, which merged the broader legacy v1 command path fix and regression tests in commit e4725e466. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by pull request #3739. The autotools v1 plugin crash fix was closed without merging after three weeks of review inactivity. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Fixes a fatal crash in the autotools v1 plugin during autogen.sh or bootstrap. Closed without merging and superseded by pull request #3739 after three weeks of inactivity awaiting review. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#3739
(confidence 100%)
Superseding PR merged the broader legacy-plugin command-path fix as e4725e466.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3628 Autotools Plugin (v1): Fix fatal crash when running autogen.sh or bootstrap | snapcraft | merged | Merged in commit 8e2cf1a25, converting autogen.sh and bootstrap Path values to strings before shlex quoting. Follow-up #3739 generalized the legacy-plugin fix. | |
| #1882425 autotools plugin should still honour autogen.sh if present | snapcraft (launchpad) | closed | Autotools v2 gained autogen.sh/bootstrap fallback support in canonical/snapcraft#3398, merged as 3fabd01b9 and released before the issue was closed. | |
| #3398 autotools v2 plugin: support autogen.sh and bootstrap | snapcraft | merged | Merged into master in commit 3fabd01b9, adding autogen.sh and bootstrap script support to the autotools v2 plugin. | |
| #1661424 autotools plugin crashes while running ./configure | snapcraft (launchpad) | closed | Resolved by upgrading: the reporter confirmed the autotools configure crash was gone in Snapcraft 2.29 and requested closure. | |
| #3601 autotools v1 plugin: set correct file permissions for scripts (CRAFT-666) | snapcraft | merged | Merged PR #3601 in commit 43eb836d8, fixing Autotools v1 permissions for non-executable autogen.sh and bootstrap scripts and simplifying the implementation. | |
| #1018 autotools: extend Make plugin instead of repeating code | snapcraft | closed | Closed after inactivity; the same Autotools-to-Make plugin refactor was re-proposed in snapcraft#1076 and merged as commit 83072a5b2. | |
| #1507648 Autotools doesn't work without autogen.sh | snapcraft (launchpad) | closed | Added an autoreconf-based Autotools option in commit 9d9a357b7 and released it in Snapcraft 0.4; later #3398 added autogen.sh/bootstrap support to v2. | |
| #1621700 autotools plugin failed with env: ‘./bootstrap’: Permission denied | snapcraft (launchpad) | closed | Autotools now ignores a bootstrap directory instead of executing it, fixing the permission-denied failure in canonical/snapcraft#803 via commit eee1b84dd. | |
| #1695081 autotools plugin should support explicit autogen or autoreconf | snapcraft (launchpad) | closed | 2014 feature request for the autotools plugin to run autogen/autoreconf. Now implemented: craft-parts runs autogen.sh, bootstrap, then `autoreconf --install` when configure is missing (snapcraft#3398, commit 3fabd01b9). | |
| #206 Autotools plugin: Set autogen.sh executable. | snapcraft | merged | Merged PR #206 fixed LP #1530995 by making autogen.sh executable when needed and adding Autotools plugin tests (commit 85405240f). |