lifecycle: do not stage deps for pull on core20 (CRAFT-725)
Metadata
Current evaluation
Merged as f30701a8c to skip dependency staging during core20 pulls, then reverted by #3620 after PULL build failures; #3622 replaced it with build-attributes-controlled behavior.
Resolution: closed superseded
Reason: The original CRAFT-725 change caused core20 PULL build failures and was reverted by merged PR #3620 (4c23512f4). PR #3622 subsequently superseded it with an opt-in build-attributes implementation.
Evaluated by: mr-cal-bot
No scores available.
Issue body
core20 uses Plugins V2, there is no plugin logic required from a dependency for
pulling like for V1 Plugins.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Merged as f30701a8c to skip dependency staging during core20 pulls, then reverted by #3620 after PULL build failures; #3622 replaced it with build-attributes-controlled behavior. | |
| stealth/space-bunny-alpha | — | closed superseded | Merged in f30701a8c, then reverted by #3620 after core20 PULL build failures. PR #3622 later restored the behavior as a build-attributes opt-in. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to stop staging dependencies for the pull step on core20, aligning with Plugins V2. A reviewer reported a regression breaking telegram-desktop snap builds, but the change was still merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to skip staging dependencies during the pull step on core20, as Plugins V2 requires none. The change caused a regression, breaking the telegram-desktop snap build due to missing staged patch files. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
snapcraft#3620
(confidence 99%)
Merged revert of f30701a8c after missing staged patches broke core20 PULL builds.
-
Superseded By:
snapcraft#3622
(confidence 98%)
Replacement PR made the lifecycle behavior conditional on a build-attributes entry.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3641 lifecycle: fix behavior for core22-step-dependencies (CRAFT-733) | snapcraft | merged | Merged PR #3641, fixing core22 step dependencies so PULL prerequisites are honored during pull rather than deferred to stage, avoiding incorrect re-pulls in pull-then-snap builds. | |
| #3620 Revert "lifecycle: do not stage deps for pull on core20" | snapcraft | merged | PR #3620 by sergiusens merged as4c23512f4 (merge cfb8ec3f5), reverting commit f30701a8c "lifecycle: do not stage deps for pull on core20" which broke core20 PULL builds in 6.0.1. | |
| #5675 Remove core20 lifecycle | snapcraft | closed | Merged PR #6019 via commit fa7952b4d, removing core20 build/lifecycle support and core20 command entries; core20 spread tests were removed separately in PR #6009. | |
| #3622 lifecycle: core22 lifecycle conditional on build-attributes entry (CRAFT-725) | snapcraft | merged | Merged PR #3622 as commit 3a9695ab7, making the core22 lifecycle conditional on a part's build-attributes entry. | |
| #3587 lifecycle: init with core20 (CRAFT-517) | snapcraft | merged | PR #3587 updated lifecycle initialization to use core20 and merged into master as f91632aab (PR commit 0458b9c). |