lifecycle: do not stage deps for pull on core20 (CRAFT-725)
Metadata
Current evaluation
Merged to stop staging dependencies for the pull step on core20, aligning with Plugins V2. A reviewer reported a regression breaking telegram-desktop snap builds, but the change was still merged.
Suggested action: —
No scores available.
Issue body
core20 uses Plugins V2, there is no plugin logic required from a dependency for
pulling like for V1 Plugins.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to stop staging dependencies for the pull step on core20, aligning with Plugins V2. A reviewer reported a regression breaking telegram-desktop snap builds, but the change was still merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to skip staging dependencies during the pull step on core20, as Plugins V2 requires none. The change caused a regression, breaking the telegram-desktop snap build due to missing staged patch files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to skip staging dependencies during pull for core20 plugin v2. A maintainer later reported the change broke telegram-desktop snap builds due to missing patch files. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3641 lifecycle: fix behavior for core22-step-dependencies (CRAFT-733) | snapcraft | merged | Merged fix for core22-step-dependencies lifecycle behavior. Corrected PULL dependencies being incorrectly treated as STAGE, which caused unwanted re-pulling. Approved, passed CI, and merged into main as commit aa8e685. | |
| #3620 Revert "lifecycle: do not stage deps for pull on core20" | snapcraft | merged | Merged a revert to restore core20 dependency staging, fixing build workflow breakages. Approved and merged by maintainer sergiusens to resolve staging regressions. | |
| #2144 lifecycle: automatically stage dependencies | snapcraft | merged | Merged PR #2144 resolves LP: #1774018 by automatically staging dependencies when a part depends on another, preventing a RuntimeError during snapcraft pull. Approved, passed CI, and achieved 100% diff coverage. | |
| #5675 Remove core20 lifecycle | snapcraft | closed | Merged in pull request #6019. Removed core20 lifecycle commands, spread tests, and plugin/extension references. Legacy components were retained for store compatibility. Prepares Snapcraft for version 9. |