← Back to issue list

lifecycle: fix behavior for core22-step-dependencies (CRAFT-733)

View original Github issue

Metadata

Project
snapcraft
Number
#3641
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3641, fixing core22 step dependencies so PULL prerequisites are honored during pull rather than deferred to stage, avoiding incorrect re-pulls in pull-then-snap builds.

Resolution: closed resolved

Reason: PR #3641 was merged into main. Commit 3e807e3e5 corrected core22 step-dependency behavior for PULL and added tests covering the pull-then-snap workflow.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- The previous behaviour was that the dependency for PULL was in effect STAGE, with produced a wrong re-pulling when doing `snapcraft pull` and then a `snapcraft snap`. See [LP#1957915](https://bugs.launchpad.net/snapcraft/+bug/1957915) for more info.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3641, fixing core22 step dependencies so PULL prerequisites are honored during pull rather than deferred to stage, avoiding incorrect re-pulls in pull-then-snap builds.
stealth/space-bunny-alpha — closed resolved Merged PR #3641 in commit 5969c32bb, fixing core22 step dependencies so PULL no longer inherits STAGE and avoids unwanted re-pulls during snapcraft snap.
stealth/space-bunny-alpha — closed resolved Merged PR #3641 (commit 5969c32bb), fixing core22 step dependencies so PULL is no longer incorrectly treated as STAGE, preventing unintended re-pulls during snapcraft snap.
qwen/qwen3.6-35b-a3b — — Merged fix for core22-step-dependencies lifecycle behavior. Corrected PULL dependencies being incorrectly treated as STAGE, which caused unwanted re-pulling. Approved, passed CI, and merged into main as commit aa8e685.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for core22 step-dependencies lifecycle. Corrected PULL dependencies incorrectly treated as STAGE, preventing erroneous re-pulling. Resolves CRAFT-733 and LP#1957915.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3610 lifecycle: do not stage deps for pull on core20 (CRAFT-725) snapcraft merged Merged as f30701a8c to skip dependency staging during core20 pulls, then reverted by #3620 after PULL build failures; #3622 replaced it with build-attributes-controlled behavior.
83%
#3620 Revert "lifecycle: do not stage deps for pull on core20" snapcraft merged PR #3620 by sergiusens merged as4c23512f4 (merge cfb8ec3f5), reverting commit f30701a8c "lifecycle: do not stage deps for pull on core20" which broke core20 PULL builds in 6.0.1.
76%
#3622 lifecycle: core22 lifecycle conditional on build-attributes entry (CRAFT-725) snapcraft merged Merged PR #3622 as commit 3a9695ab7, making the core22 lifecycle conditional on a part's build-attributes entry.
71%
#3587 lifecycle: init with core20 (CRAFT-517) snapcraft merged PR #3587 updated lifecycle initialization to use core20 and merged into master as f91632aab (PR commit 0458b9c).
70%