← Back to issue list

lifecycle: fix behavior for core22-step-dependencies (CRAFT-733)

View original Github issue

Metadata

Project
snapcraft
Number
#3641
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged fix for core22-step-dependencies lifecycle behavior. Corrected PULL dependencies being incorrectly treated as STAGE, which caused unwanted re-pulling. Approved, passed CI, and merged into main as commit aa8e685.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- The previous behaviour was that the dependency for PULL was in effect STAGE, with produced a wrong re-pulling when doing `snapcraft pull` and then a `snapcraft snap`. See [LP#1957915](https://bugs.launchpad.net/snapcraft/+bug/1957915) for more info.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for core22-step-dependencies lifecycle behavior. Corrected PULL dependencies being incorrectly treated as STAGE, which caused unwanted re-pulling. Approved, passed CI, and merged into main as commit aa8e685.
qwen3.6-35b-a3b-mtp-q6 Merged fix for core22 step-dependencies lifecycle. Corrected PULL dependencies incorrectly treated as STAGE, preventing erroneous re-pulling. Resolves CRAFT-733 and LP#1957915.
qwen3.6-35b-a3b-mtp-q6 Merged into main to correct core22 step dependency logic where PULL was misclassified as STAGE, preventing unintended re-pulling during builds. Resolves CRAFT-733 and LP#1957915.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3610 lifecycle: do not stage deps for pull on core20 (CRAFT-725) snapcraft merged Merged to stop staging dependencies for the pull step on core20, aligning with Plugins V2. A reviewer reported a regression breaking telegram-desktop snap builds, but the change was still merged.
79%
#3620 Revert "lifecycle: do not stage deps for pull on core20" snapcraft merged Merged a revert to restore core20 dependency staging, fixing build workflow breakages. Approved and merged by maintainer sergiusens to resolve staging regressions.
75%
#2144 lifecycle: automatically stage dependencies snapcraft merged Merged PR #2144 resolves LP: #1774018 by automatically staging dependencies when a part depends on another, preventing a RuntimeError during snapcraft pull. Approved, passed CI, and achieved 100% diff coverage.
74%
#3587 lifecycle: init with core20 (CRAFT-517) snapcraft merged Merged lifecycle initialization update to core20. Approved by one reviewer, passed CI checks, and applied a minimal two-line change across two files with no coverage impact.
72%