Revert "lifecycle: do not stage deps for pull on core20"
Metadata
Current evaluation
PR #3620 by sergiusens merged as4c23512f4 (merge cfb8ec3f5), reverting commit f30701a8c "lifecycle: do not stage deps for pull on core20" which broke core20 PULL builds in 6.0.1.
Resolution: closed resolved
Reason: The PR itself was merged into master as commit 4c23512f4 (merge commit cfb8ec3f5), restoring dependency staging on core20 after reports that separate parts' staged files were missing. Follow-up PR #3622 (commit 3a9695ab7) reintroduced the behaviour as a core22 build-attributes opt-in.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This reverts commit f30701a8c5aaa6d1a4290751bbcfbdf86f6a8623.
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #3620 by sergiusens merged as4c23512f4 (merge cfb8ec3f5), reverting commit f30701a8c "lifecycle: do not stage deps for pull on core20" which broke core20 PULL builds in 6.0.1. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3620 (commit 4c23512f4), reverting f30701a8c5 to restore dependency staging during core20 PULL and fix broken build workflows. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a revert to restore core20 dependency staging, fixing build workflow breakages. Approved and merged by maintainer sergiusens to resolve staging regressions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged revert of commit f30701a8c5aaa6d1a4290751bbcfbdf86f6a8623. Original change broke workflows by blocking file staging during core20 pull. Revert restores dependency staging and fixes the regression. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#3610
(confidence 85%)
Original PR merged as f30701a8c whose change this PR reverts after core20 PULL build failures
-
Superseded By:
canonical/snapcraft#3622
(confidence 80%)
Follow-up PR restoring the no-stage PULL behaviour as an opt-in build-attributes flag on core22
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3610 lifecycle: do not stage deps for pull on core20 (CRAFT-725) | snapcraft | merged | Merged as f30701a8c to skip dependency staging during core20 pulls, then reverted by #3620 after PULL build failures; #3622 replaced it with build-attributes-controlled behavior. | |
| #3641 lifecycle: fix behavior for core22-step-dependencies (CRAFT-733) | snapcraft | merged | Merged PR #3641, fixing core22 step dependencies so PULL prerequisites are honored during pull rather than deferred to stage, avoiding incorrect re-pulls in pull-then-snap builds. | |
| #5675 Remove core20 lifecycle | snapcraft | closed | Merged PR #6019 via commit fa7952b4d, removing core20 build/lifecycle support and core20 command entries; core20 spread tests were removed separately in PR #6009. |