← Back to issue list

Revert "lifecycle: do not stage deps for pull on core20"

View original Github issue

Metadata

Project
snapcraft
Number
#3620
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged a revert to restore core20 dependency staging, fixing build workflow breakages. Approved and merged by maintainer sergiusens to resolve staging regressions.

Suggested action: —

No scores available.

Issue body

This reverts commit f30701a8c5aaa6d1a4290751bbcfbdf86f6a8623. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a revert to restore core20 dependency staging, fixing build workflow breakages. Approved and merged by maintainer sergiusens to resolve staging regressions.
qwen3.6-35b-a3b-mtp-q6 — — Merged revert of commit f30701a8c5aaa6d1a4290751bbcfbdf86f6a8623. Original change broke workflows by blocking file staging during core20 pull. Revert restores dependency staging and fixes the regression.
qwen3.6-35b-a3b-mtp-q6 — — Merged a revert of commit f30701a8c5aaa6d1a4290751bbcfbdf86f6a8623. The original change broke core20 dependency staging, breaking snapcraft 6.0.1 builds. The revert restores staging behavior and resolves the regression.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3610 lifecycle: do not stage deps for pull on core20 (CRAFT-725) snapcraft merged Merged to stop staging dependencies for the pull step on core20, aligning with Plugins V2. A reviewer reported a regression breaking telegram-desktop snap builds, but the change was still merged.
77%
#3641 lifecycle: fix behavior for core22-step-dependencies (CRAFT-733) snapcraft merged Merged fix for core22-step-dependencies lifecycle behavior. Corrected PULL dependencies being incorrectly treated as STAGE, which caused unwanted re-pulling. Approved, passed CI, and merged into main as commit aa8e685.
75%