← Back to issue list

legacy: plugins: convert paths to strings for commands

View original Github issue

Metadata

Project
snapcraft
Number
#3739
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #3739 (commit e4725e466), converting legacy v1 plugin command paths to strings and adding regression tests, completing the partial fix in #3628.

Resolution: closed resolved

Reason: PR #3739 was merged as e4725e466 with implementation commit 13702bf1. It fixed pathlib path handling centrally in the legacy v1 plugin command path and added regression tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> - [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Convert `Path` to `string` for commands in legacy v1 plugins. Add regression tests. Bug was exposed when https://github.com/snapcore/snapcraft/pull/3601/files started using `pathlib` for `autotools`. @diddledani partially fixed the issue https://github.com/snapcore/snapcraft/pull/3628, but this PR should wrap up the issue.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #3739 (commit e4725e466), converting legacy v1 plugin command paths to strings and adding regression tests, completing the partial fix in #3628.
stealth/space-bunny-alpha — closed resolved Merged #3739 (commit e4725e466), converting legacy v1 plugin command paths to strings and adding regression tests, completing the partial fix from #3628.
stealth/space-bunny-alpha — closed resolved Merged #3739 (commit e4725e466) to convert pathlib paths to strings in legacy v1 plugin commands and add regression tests, completing the broader fix after #3628.
qwen/qwen3.6-35b-a3b — — Merged PR converting pathlib.Path objects to strings in legacy v1 plugin commands, resolving a bug from pathlib adoption. Includes regression tests and complements PR #3628. Approved and merged by maintainer.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Converts Path objects to strings for commands in legacy v1 plugins, resolving a bug triggered by pathlib migration. Includes regression tests and complements a prior partial fix.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3628 (confidence 99%)

    Partial autotools-specific fix retained alongside the broader #3739 solution.

  • Duplicate Of: snapcraft#3694 (confidence 98%)

    Implemented the same autotools fix; #3739 superseded it with broader coverage and tests.

  • Caused By: snapcraft#3601 (confidence 95%)

    Its use of pathlib exposed commands that could not accept Path values.

Related issues

No related issues found above the similarity threshold.