store: login requires no exported credentials
Metadata
Current evaluation
Merged into main following reviewer approval and passing CI. The update modifies store login to require no exported credentials, changing 3 files (+29/-4 lines). Code coverage increased by 0.01% with 100% diff coverage.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1148
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main following reviewer approval and passing CI. The update modifies store login to require no exported credentials, changing 3 files (+29/-4 lines). Code coverage increased by 0.01% with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Updated store login logic to eliminate the requirement for exported credentials. The change passed all checks and was merged with 100% diff coverage, slightly increasing overall test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main, resolving CRAFT-1148 by removing the requirement for exported credentials during store login. The commit achieved 100% diff coverage and increased overall coverage by 0.01%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3797 store: export-login with legacy | snapcraft | merged | Merged to main. Resolves export-login to stop prioritizing legacy credentials during export. Approved, passed CI, and maintained 100% coverage. | |
| #3468 store: set auth headers when using login --with | snapcraft | merged | Merged into master after two approvals and passing CI. Adds 29 lines and removes 8 across three files to set auth headers for login --with. Diff coverage is 100% with no overall coverage impact. | |
| #3466 store: do not unnecessarily catch/rewrite exceptions | snapcraft | merged | Merged into master. Removes unnecessary exception handling in store module login functions to surface original errors for debugging. Drops unused error constants and updates tests. Approved with passing CI and 100% diff coverage. | |
| #3799 export-login: clarify use of exported tokens | snapcraft | merged | Merged clarification on exported token usage in export-login. Updated two files (+50/-3 lines). CI passed with 100% diff coverage. Unrelated upload failures and a minor coverage drop did not block the merge. | |
| #3809 store: correct login for register-key | snapcraft | merged | Merged into main following reviewer approval and passing CI checks. The change corrects login handling for register-key by implementing proper exit handling on errors. The commit adds 23 lines and removes 1 across two files. | |
| #3805 store: support configparser credentials | snapcraft | merged | Merged into main. Adds configparser credential support to the store module. Approved by one reviewer, passed CI checks, and modified 10 files (+217/-58 lines). Test coverage increased by 0.14%. | |
| #903 store: download without login | snapcraft | merged | Merged a maintainer pull request enabling store downloads without login. The change updates five files, reduces code by twelve lines, and resolves Launchpad bug #1606903. |