store: login requires no exported credentials
Metadata
Current evaluation
Merged into main as commit 7e6ef4514, updating store login so it no longer requires exported credentials for CRAFT-1148.
Resolution: closed resolved
Reason: PR #3808 was merged into main as commit 7e6ef4514. The change updated store login behavior for CRAFT-1148 to remove the exported-credentials requirement.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1148
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into main as commit 7e6ef4514, updating store login so it no longer requires exported credentials for CRAFT-1148. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3808 as commit 7e6ef4514, preventing store login when exported store credentials are present (CRAFT-1148). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3808 as commit 7e6ef4514, updating store login to reject unsupported exported credentials for CRAFT-1148. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main as commit 7e6ef4514, allowing `store login` to run without pre-exported credentials and adding test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main as commit 7e6ef4514 (#3808), updating store login to require no exported credentials for CRAFT-1148. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main following reviewer approval and passing CI. The update modifies store login to require no exported credentials, changing 3 files (+29/-4 lines). Code coverage increased by 0.01% with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Updated store login logic to eliminate the requirement for exported credentials. The change passed all checks and was merged with 100% diff coverage, slightly increasing overall test coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3797 store: export-login with legacy | snapcraft | merged | Merged PR #3797 as commit fbc65bb38, ensuring legacy credentials do not take precedence when exporting a store login. | |
| #3794 store: full support for legacy login | snapcraft | merged | Merged PR #3794 via commit 86193a7b4 (7194ef18d), restoring legacy-login compatibility by using existing Snapcraft credentials to build craft-store authorization headers. | |
| #602 Added an export option to login to save the obtained credentials (CRAFT-641). | charmcraft | merged | Merged #602 via commit f0e57248, adding login --export support to save obtained credentials and implementing CRAFT-641. | |
| #903 store: download without login | snapcraft | merged | Merged PR #903 in commit 603948e1d, removing the login requirement for Store downloads and resolving the related Launchpad credential issue. | |
| #6098 fix: Tweak error message about SNAPCRAFT_STORE_CREDENTIALS | snapcraft | merged | Merged in commit ee69b79b1, clarifying that login cannot be used while SNAPCRAFT_STORE_CREDENTIALS is set and removing ambiguous wording. |