← Back to issue list

requirements: update craft-parts to 1.8.1

View original Github issue

Metadata

Project
snapcraft
Number
#3825
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in commit ec81c5082, upgrading craft-parts to 1.8.1 to fix empty scriptlet execution (LP #1978966).

Resolution: closed resolved

Reason: PR #3825 was merged as commit ec81c5082. It adopted craft-parts 1.8.1, which includes the empty-scriptlet fix merged in canonical/craft-parts#242.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Craft-parts 1.8.1 fixes empty scriptlet execution. LP: #1978966 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1183

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit ec81c5082, upgrading craft-parts to 1.8.1 to fix empty scriptlet execution (LP #1978966).
stealth/space-bunny-alpha — closed resolved Merged in #3825 (commit ec81c5082), upgrading craft-parts to 1.8.1 to fix empty scriptlet execution (LP #1978966).
qwen/qwen3.6-35b-a3b — — Merged update to craft-parts 1.8.1, resolving the empty scriptlet execution bug (LP #1978966). Approved by reviewers, passed CI, and maintained code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main, updating the craft-parts dependency to 1.8.1 to fix empty scriptlet execution (LP #1978966). The change was integrated without impacting overall code coverage.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#242 (confidence 100%)

    Merged commit 4dd2a4a0 added handling for empty scriptlets and was released in craft-parts 1.8.1.

Related issues

Issue Project State Summary Similarity
#191 requirements: update craft-parts to 1.18.1 rockcraft merged Merged PR #191 as commit 6fae4cbf, updating craft-parts to 1.18.1 to fix ignored file patterns in local-source processing.
81%
#3851 requirements: update craft-parts snapcraft closed The craft-parts 1.10.1 update was bundled into #3848 and merged into release/7.1 as 2dadaa6da; #3851 was closed unmerged.
79%
#579 requirements: update craft-parts to 1.0.3 (CRAFT-577) charmcraft merged Merged into main via #579 (merge commit 8c928d83), updating craft-parts from 1.0.2 to 1.0.3 in two requirement files for CRAFT-577.
79%
#4334 requirements: update craft-parts to 1.24.1 snapcraft merged Merged PR #4334 as commit 9ad7a93ea, updating craft-parts to 1.24.1 for a workaround to a craft-cli spinner deadlock.
79%
#1021 requirements: update craft-parts to 1.18.1 charmcraft merged PR #1021 merged (commit e00cbd66, body commit 58669bb1), bumping craft-parts from 1.18.0 to 1.18.1 in requirements.txt and requirements-dev.txt to pick up the fix for ignored file patterns in local sources.
79%
#4168 requirements: update craft-parts to 1.19.4 snapcraft closed Update to craft-parts 1.19.4 was closed unmerged as superseded by #4173, which updated to 1.19.5 in commit f0f5fca3a.
78%
#4158 requirements: update craft-parts to 1.20.0 snapcraft closed Closed unmerged: cmatsuoka marked it superseded by merged PR #4183, which bumped craft-parts to 1.21.0 instead of 1.20.0 in commit 8f6a8b353 (targeted at 8.x, not 7.4.0).
78%
#4027 requirements: update craft-parts to 1.18.1 snapcraft merged Merged #4027 as 46791aad5, updating two requirement files to craft-parts 1.18.1 so ignored file patterns are honored for local sources.
78%
#592 requirements: update craft-parts to 1.0.4 charmcraft merged Merged PR #592 updated Charmcraft's craft-parts dependency from 1.0.3 to 1.0.4; commit 361e6bcf was merged via 6f383549.
78%
#4083 requirements: update craft-parts to 1.19.0 snapcraft merged Merged PR #4083 (commit 0e2cf91be) bumped craft-parts to 1.19.0, adopting feature selection that makes the overlay step optional and improving dirty checks for plugin-specific property changes.
78%