← Back to issue list

tests: enable provider spread tests for core22

View original Github issue

Metadata

Project
snapcraft
Number
#3877
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 7612a3a87: renamed the spread test dir build-providers to providers and moved legacy-only tests into providers/legacy, enabling provider spread tests on core22 (CRAFT-1266). Prerequisite for #3875.

Resolution: closed resolved

Reason: The PR was approved and merged into hotfix/7.1.2 as commit 7612a3a87, adding core22 support to tests/spread/providers and reorganizing legacy tests into a legacy/ subdirectory. The author confirmed in the PR thread that the core22 tests execute as expected on the Google ubuntu-18.04/20.04 hosts.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Enable spread tests for core22 to test usage of `providers`. This PR is a prerequisite to https://github.com/snapcore/snapcraft/pull/3875, which will add more spread tests. I changed the spread test folder from `build-providers` (legacy name) to `providers` (new name), then I moved the legacy-only tests into a subdir called `legacy`. (CRAFT-1266)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 7612a3a87: renamed the spread test dir build-providers to providers and moved legacy-only tests into providers/legacy, enabling provider spread tests on core22 (CRAFT-1266). Prerequisite for #3875.
stealth/space-bunny-alpha — closed resolved PR #3877 merged as 7612a3a87, enabling core22 provider spread tests; renamed build-providers to providers and moved legacy-only tests into providers/legacy.
stealth/space-bunny-alpha — closed resolved Merged as 7612a3a87: enabled core22 provider spread tests, renamed build-providers to providers, and moved legacy tests into a legacy subdirectory.
qwen/qwen3.6-35b-a3b — — Merged updates enabling provider spread tests for core22. The test directory was renamed from build-providers to providers, and legacy tests were relocated to a legacy subdirectory. Approved and merged following successful CI validation.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Enabled core22 provider spread tests by renaming the test directory from build-providers to providers and moving legacy tests to a legacy subdirectory. Execution verified via GitHub logs with no coverage impact.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3875 (confidence 90%)

    PR body names #3875 as the follow-up this enables (that PR later added more spread tests, commit c1cc43cb8)

  • Related To: canonical/snapcraft#6074 (confidence 55%)

    Later commit db7c53f21 removed the default command, which eventually removed tests/spread/providers

Related issues

Issue Project State Summary Similarity
#6202 test(spread): create core26 spread test suite snapcraft merged Merged PR #6202 as a9a5b4750, adding core26 Spread tests and CI coverage while generalizing common tests for core22, core24, and core26.
79%
#3714 spread: enable core22 snapcraft merged Merged PR #3714 enabled core22 in the Spread test configuration. Implementation commit d2f2a0d43 landed via merge commit 6b42ca1bb.
79%
#1114 test: enable pro spread tests craft-application merged Merged canonical/craft-application#1114, raising craft-providers to >=3.7.1 and re-enabling Ubuntu Pro spread tests.
77%
#488 test(spread): test sector writing in all providers imagecraft merged Merged PR adding spread tests to verify sector writing across all providers, addressing CRAFT-5332.
75%
#6164 test(spread): add core26 package-cutoff test snapcraft merged Merged #6164 in commit 927e31121, adding core26 package-cutoff spread coverage. It incorporates #6171 and fixes #6146 and #6148.
75%
#4056 spread: core24 testing infra snapcraft merged Merged PR #4056 as commit 1fee3d830, adding Spread test infrastructure for Ubuntu Core 24 (CRAFT-1639).
74%
#16 tests: add spread support rockcraft merged Merged PR #16 added Spread support for CRAFT-865 via commit 3aeba2b3 (merge commit 5bf2680a).
74%
#6009 test: remove core20 spread tests snapcraft merged Squash-merged PR #6009 as commit d0f1b4394, deleting core20 spread tests and migrating applicable ones to core22/core24 (+20 net tests). Unblocked core20 lifecycle removal for Snapcraft 9 (#5675).
74%
#4932 Migrate or copy core20 and core22 spread tests to core24 snapcraft closed Core24 spread-test coverage was expanded via merged PR snapcraft#5209 (commit 56713c384), enabling plugin tests across 132 files.
74%
#1325 test(spread): consolidate basic init/build tests charmcraft merged Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files.
74%