test: remove core20 spread tests
Metadata
Current evaluation
Squash-merged PR #6009 as commit d0f1b4394, deleting core20 spread tests and migrating applicable ones to core22/core24 (+20 net tests). Unblocked core20 lifecycle removal for Snapcraft 9 (#5675).
Resolution: closed resolved
Reason: The PR itself was the resolution: merged to main as commit d0f1b4394 ("test: remove core20 spread tests (#6009)"), verified in the file history of tests/spread/general/sources. It was explicitly opened to unblock #5675, which was then closed by the follow-up PR #6019 (fa7952b4d).
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is the first part of removing core20 for Snapcraft 9. It removes core20 spread tests.
This has only improved test coverage for core22+. I don't think anything was removed that has relevance for modern snapcraft.
Test changes:
+19 core22 tests (163 -> 182)
+1 core24 tests (107 -> 108)
| tests | notes |
| --------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| plugins/core20 (v2) plugins | removed, specific to core20 |
| core20/manifest | already tested for core22, core24 |
| cross-compile/ | removed, core24 cross-compiling is already tested and core20 cross-compiling is very different |
| extensions/ros1 (noetic) | removed, specific to core20 |
| extensions/ros2 (foxy) | removed, specific to core20 |
| extensions/gnome-3-38 | removed, specific to core20 |
| general/build-aux | migrated to core22
| general/build-environment | migrated to core22 ||
| general/core22-step-dependencies | removed, specific to core20 (despite what the name suggests) |
| general/fix-symlink tests | migrated to core22 |
| general/stub-hooks | untested, now tested on core22 |
| general/passthrough | migrated to core22 |
| ~~general/patchelf~~ | ~~check me~~ |
| general/project-variables | removed, already tested for core22 and core24 |
| general/sources | migrated to core22<br>- exposed a bug in the 7z source (https://github.com/canonical/craft-parts/issues/1443) |
| general/stage-snaps-normalization | migrated to core22 |
| providers/legacy/ | removed, specific to core20 |
| providers/lxd-type-base | removed, already tested in core22 |
| snaps/ | removed maas and microk8s due to being very outdated<br>all snaps except for snapd weren't being tested and I'm not going to enable them here<br>snapd was migrated to core22 |
Unblocks #5675
(SNAPCRAFT-1195)
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Squash-merged PR #6009 as commit d0f1b4394, deleting core20 spread tests and migrating applicable ones to core22/core24 (+20 net tests). Unblocked core20 lifecycle removal for Snapcraft 9 (#5675). | |
| stealth/space-bunny-alpha | — | closed resolved | Squash-merged #6009 as d0f1b4394, removing core20 spread tests and migrating applicable coverage to core22/core24. The cleanup unblocks core20 removal for Snapcraft 9 (#5675). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of core20 spread tests and migration of related cases to core22 and core24. This update unblocks core20 deprecation for Snapcraft 9 and improves modern test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of core20 spread tests, migrating remaining tests to core22 and core24. This improves modern test coverage, exposes a craft-parts bug, and unblocks issue #5675. Reported spread failures were unrelated. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#5675
(confidence 96%)
PR body states "Unblocks #5675"; that core20 lifecycle removal issue was later closed by PR #6019 (fa7952b4d).
-
Likely Fixed By:
canonical/snapcraft#6019
(confidence 90%)
Follow-up merged PR that completed core20 removal, consuming the test cleanup done here.
-
Caused By:
canonical/craft-parts#1443
(confidence 55%)
PR body cites a 7z source bug exposed by the migrated general/sources core22 test; not resolved by this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3026 spread tests: add core20 and cleanup systems | snapcraft | merged | Merged #3026 in commit d006134d4, adding core20 spread tests, simplifying setup to install only the Snap, and cleaning up test systems. | |
| #5675 Remove core20 lifecycle | snapcraft | closed | Merged PR #6019 via commit fa7952b4d, removing core20 build/lifecycle support and core20 command entries; core20 spread tests were removed separately in PR #6009. | |
| #4932 Migrate or copy core20 and core22 spread tests to core24 | snapcraft | closed | Core24 spread-test coverage was expanded via merged PR snapcraft#5209 (commit 56713c384), enabling plugin tests across 132 files. | |
| #4763 tests: remove core24 snap workarounds (#4761) | snapcraft | merged | Merged: cherry-pick of #4761 onto main (87fc77aca), deleting 22 lines of core24 snap workarounds from spread tests so CI would pass. | |
| #4761 tests: remove core24 snap workarounds | snapcraft | merged | Merged #4761 removed 22 lines of core24 workarounds from spread tests; it landed on hotfix/8.2 as 7cdd9b087 and was cherry-picked to main by #4763 as 87fc77aca. | |
| #3269 spread tests: remove references of core16 | snapcraft | merged | Merged PR #3269 via commit ab84886f2, removing core16 references from three spread-test files. | |
| #77 core22-8 spread tests fail on classic-patchelf test | snapcraft-rocks | closed | Fixed by merged PR #80, a core22-8 backport of #69 that enabled verbose output so Snapcraft messages appear in failing spread-test logs. | |
| #6202 test(spread): create core26 spread test suite | snapcraft | merged | Merged PR #6202 as a9a5b4750, adding core26 Spread tests and CI coverage while generalizing common tests for core22, core24, and core26. | |
| #4182 Add electron-builder test for core20 | snapcraft | open | Requested core20 electron-builder spread coverage is obsolete: core20 support and related tests were removed in PRs #6019 and #6009, and core20 is now limited to the legacy Snapcraft 8.x track. | |
| #4177 core18: removal | snapcraft | merged | Merged PR snapcore/snapcraft#4177 (May 2023) dropped core18 base support and its unit/spread tests, fixing #4165 via commits 40136ea9b, 77edc734b and ed423b6a8; core18 was EOL. |