requirements: update craft-parts to 1.12.0
Metadata
Current evaluation
PR to bump craft-parts to 1.12.0 was closed unmerged by cmatsuoka in favor of #3879 (craft-parts 1.12.1), which was merged to hotfix/7.1.2 in commit 835d7260d to fix the CMake prefix-path issue (LP #1978859).
Resolution: closed superseded
Reason: The author closed the PR without merging, commenting "Closing in favor of #3879." The superseding PR #3879, which bumped craft-parts to 1.12.1 to correct the cmake plugin's CMAKE_PREFIX_PATH value, was merged into hotfix/7.1.2 as commit 835d7260d.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Use craft-parts 1.12.0 with changes to the cmake plugin to fix the
prefix path and install prefix. This allows libraries built using
cmake and staged from a different part to be recognized without
defining cmake plugin parameters such as `CMAKE_INCLUDE_PATH` or
`CMAKE_LIBRARY_PATH`.
LP: #1978859
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR to bump craft-parts to 1.12.0 was closed unmerged by cmatsuoka in favor of #3879 (craft-parts 1.12.1), which was merged to hotfix/7.1.2 in commit 835d7260d to fix the CMake prefix-path issue (LP #1978859). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed in favor of #3879, which updated craft-parts to 1.12.1 to address the cmake prefix-path fix. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by pull request #3879. The author closed this craft-parts 1.12.0 update for cmake prefix path fixes in favor of a consolidated follow-up pull request. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by pull request #3879. The craft-parts 1.12.0 update was closed by the author to consolidate changes in the follow-up pull request. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#3879
(confidence 98%)
Author explicitly closed this PR in favor of #3879 (craft-parts 1.12.1), merged to hotfix/7.1.2 as 835d7260d
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3879 requirements: update craft-parts to 1.12.1 | snapcraft | merged | PR #3879 by cmatsuoka bumped craft-parts to 1.12.1, merged as commit 835d7260d into hotfix/7.1.2 (snapcraft 7.1.2). Fixes a bug in the CMake plugin's CMAKE_PREFIX_PATH value (canonical/craft-parts#263/#268). | |
| #4158 requirements: update craft-parts to 1.20.0 | snapcraft | closed | Closed unmerged: cmatsuoka marked it superseded by merged PR #4183, which bumped craft-parts to 1.21.0 instead of 1.20.0 in commit 8f6a8b353 (targeted at 8.x, not 7.4.0). | |
| #4030 requirements: update craft-parts to 1.15.3 | snapcraft | merged | Merged PR #4030 as commit 524866d22 into hotfix/7.2, updating craft-parts to 1.15.3 to honor ignored file patterns for local sources. | |
| #3851 requirements: update craft-parts | snapcraft | closed | The craft-parts 1.10.1 update was bundled into #3848 and merged into release/7.1 as 2dadaa6da; #3851 was closed unmerged. | |
| #592 requirements: update craft-parts to 1.0.4 | charmcraft | merged | Merged PR #592 updated Charmcraft's craft-parts dependency from 1.0.3 to 1.0.4; commit 361e6bcf was merged via 6f383549. | |
| #4168 requirements: update craft-parts to 1.19.4 | snapcraft | closed | Update to craft-parts 1.19.4 was closed unmerged as superseded by #4173, which updated to 1.19.5 in commit f0f5fca3a. | |
| #4305 requirements: update craft-parts to 1.19.7 | snapcraft | merged | Merged #4305 into hotfix/7.5, updating craft-parts to 1.19.7 so rebuilds no longer set the version twice. | |
| #4083 requirements: update craft-parts to 1.19.0 | snapcraft | merged | Merged PR #4083 (commit 0e2cf91be) bumped craft-parts to 1.19.0, adopting feature selection that makes the overlay step optional and improving dirty checks for plugin-specific property changes. | |
| #4327 requirements: update craft-parts to 1.23.1 | snapcraft | merged | Merged PR #4327 updated craft-parts to 1.23.1, fixing rebuilds that could set the version twice. | |
| #1021 requirements: update craft-parts to 1.18.1 | charmcraft | merged | PR #1021 merged (commit e00cbd66, body commit 58669bb1), bumping craft-parts from 1.18.0 to 1.18.1 in requirements.txt and requirements-dev.txt to pick up the fix for ignored file patterns in local sources. |