← Back to issue list

requirements: update craft-parts to 1.12.0

View original Github issue

Metadata

Project
snapcraft
Number
#3878
Type
pull request
State
closed
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Superseded by pull request #3879. The author closed this craft-parts 1.12.0 update for cmake prefix path fixes in favor of a consolidated follow-up pull request.

Suggested action:

No scores available.

Issue body

Use craft-parts 1.12.0 with changes to the cmake plugin to fix the prefix path and install prefix. This allows libraries built using cmake and staged from a different part to be recognized without defining cmake plugin parameters such as `CMAKE_INCLUDE_PATH` or `CMAKE_LIBRARY_PATH`. LP: #1978859 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Superseded by pull request #3879. The author closed this craft-parts 1.12.0 update for cmake prefix path fixes in favor of a consolidated follow-up pull request.
qwen3.6-35b-a3b-mtp-q6 Superseded by pull request #3879. The craft-parts 1.12.0 update was closed by the author to consolidate changes in the follow-up pull request.
qwen3.6-35b-a3b-mtp-q6 Updated craft-parts to 1.12.0 to resolve cmake plugin prefix path issues. The pull request was closed and superseded by #3879.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4333 requirements: update craft-parts to 1.24.0 snapcraft closed Superseded by pull request #4334. The author closed this craft-parts version update after approval and passing CI, opting to implement the change in a subsequent PR instead.
86%
#3851 requirements: update craft-parts snapcraft closed Superseded by PR #3848. The craft-parts 1.10.1 update was bundled into another pull request rather than merged here.
84%
#4158 requirements: update craft-parts to 1.20.0 snapcraft closed Superseded by pull request #4183. The craft-parts 1.20.0 dependency update was abandoned.
82%
#3879 requirements: update craft-parts to 1.12.1 snapcraft merged Merged craft-parts 1.12.1 update to hotfix branch 7.1.2. Resolves a cmake plugin CMAKE_PREFIX_PATH bug. Conda test failures were addressed in a separate PR.
80%
#4207 requirements: update craft-parts to 1.19.6 snapcraft merged Merged update to craft-parts 1.19.6, reverting subdir changes in pull and build steps. Approved by reviewer and passed CI checks.
78%
#4083 requirements: update craft-parts to 1.19.0 snapcraft merged Merged update to craft-parts 1.19.0, enabling optional overlay steps, feature selection, and improved dirty checking. Approved by reviewer, passed CI, and merged into main.
78%
#4208 requirements: update craft-parts to 1.21.1 snapcraft merged Merged update to craft-parts 1.21.1, reverting changes in pull and build subdirs. Approved by a reviewer, passed CI checks, and maintained existing code coverage with a minimal two-line change across two files.
77%
#1092 requirements: update craft-parts to 1.19.2 charmcraft merged Merged dependency update upgrading craft-parts to 1.19.2, resolving ignore list handling for local sources. Approved by one reviewer, passed CI checks, and integrated successfully.
76%
#1021 requirements: update craft-parts to 1.18.1 charmcraft merged Merged dependency update to craft-parts 1.18.1, fixing ignored file patterns during local source processing. Approved by one reviewer with passing CI checks.
76%
#592 requirements: update craft-parts to 1.0.4 charmcraft merged Approved and merged after updating the craft-parts dependency to version 1.0.4. The change modified two files with minimal adjustments to align with the new version.
76%