← Back to issue list

requirements: update craft-parts to 1.12.1

View original Github issue

Metadata

Project
snapcraft
Number
#3879
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #3879 by cmatsuoka bumped craft-parts to 1.12.1, merged as commit 835d7260d into hotfix/7.1.2 (snapcraft 7.1.2). Fixes a bug in the CMake plugin's CMAKE_PREFIX_PATH value (canonical/craft-parts#263/#268).

Resolution: closed resolved

Reason: The PR was approved and merged as commit 835d7260d ("requirements: update craft-parts to 1.12.1 (#3879)") into the hotfix/7.1.2 branch rather than main, since it only corrects the CMAKE_PREFIX_PATH value without changing plugin behaviour; the bump pulls in craft-parts 1.12.1 (canonical/craft-parts#268), which reverts the install-prefix change from 1.12.0. Conda spread-test failures raised in review were handled separately by #3881.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Use craft-parts 1.12.1 with fixes to cmake plugin prefix path. Note: this doesn't change the cmake plugin behavior and only fixes a bug in the `CMAKE_PREFIX_PATH` variable value, so it's targeting 7.1.2 instead of main. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3879 by cmatsuoka bumped craft-parts to 1.12.1, merged as commit 835d7260d into hotfix/7.1.2 (snapcraft 7.1.2). Fixes a bug in the CMake plugin's CMAKE_PREFIX_PATH value (canonical/craft-parts#263/#268).
stealth/space-bunny-alpha — closed resolved Merged in #3879 (835d7260d) to hotfix/7.1.2, updating craft-parts to 1.12.1 to fix the CMake plugin's CMAKE_PREFIX_PATH value.
stealth/space-bunny-alpha — closed resolved Merged #3879 in commit 835d7260, updating craft-parts to 1.12.1 for a CMake plugin CMAKE_PREFIX_PATH fix; released in 7.1.2.
qwen/qwen3.6-35b-a3b — — Merged craft-parts 1.12.1 update to hotfix branch 7.1.2. Resolves a cmake plugin CMAKE_PREFIX_PATH bug. Conda test failures were addressed in a separate PR.
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.1.2. Updates craft-parts to 1.12.1 to fix a CMAKE_PREFIX_PATH bug in the cmake plugin. Test failures from an outdated conda version were addressed separately in PR #3881.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#268 (confidence 85%)

    craft-parts 1.12.1 release containing the cmake prefix path fix that this requirements bump pulls in

  • Related To: canonical/snapcraft#3878 (confidence 80%)

    Preceding PR to update to craft-parts 1.12.0, closed in favour of this PR

  • Likely Fixed By: canonical/craft-parts#263 (confidence 78%)

    Upstream CMake plugin prefix-path fix (71b71990) that 1.12.1 addresses

  • Related To: canonical/snapcraft#3881 (confidence 70%)

    Merged PR (3a5ad3f65) fixing conda spread tests discussed during review of #3879

Related issues

Issue Project State Summary Similarity
#3878 requirements: update craft-parts to 1.12.0 snapcraft closed PR to bump craft-parts to 1.12.0 was closed unmerged by cmatsuoka in favor of #3879 (craft-parts 1.12.1), which was merged to hotfix/7.1.2 in commit 835d7260d to fix the CMake prefix-path issue (LP #1978859).
94%
#4158 requirements: update craft-parts to 1.20.0 snapcraft closed Closed unmerged: cmatsuoka marked it superseded by merged PR #4183, which bumped craft-parts to 1.21.0 instead of 1.20.0 in commit 8f6a8b353 (targeted at 8.x, not 7.4.0).
83%
#4030 requirements: update craft-parts to 1.15.3 snapcraft merged Merged PR #4030 as commit 524866d22 into hotfix/7.2, updating craft-parts to 1.15.3 to honor ignored file patterns for local sources.
82%
#4305 requirements: update craft-parts to 1.19.7 snapcraft merged Merged #4305 into hotfix/7.5, updating craft-parts to 1.19.7 so rebuilds no longer set the version twice.
82%
#4120 requirements: update craft-parts to 1.19.3 snapcraft merged Merged PR #4120 as b4fa73795, updating Snapcraft to craft-parts 1.19.3 for the planning-phase plugin-properties state fix.
81%
#3851 requirements: update craft-parts snapcraft closed The craft-parts 1.10.1 update was bundled into #3848 and merged into release/7.1 as 2dadaa6da; #3851 was closed unmerged.
80%
#4183 requirements: update craft-parts to 1.21.0 snapcraft merged Merged PR #4183 updated Snapcraft's craft-parts requirement to 1.21.0 in commit 8f6a8b353, aligning it with new base and overlay package callbacks.
80%
#4327 requirements: update craft-parts to 1.23.1 snapcraft merged Merged PR #4327 updated craft-parts to 1.23.1, fixing rebuilds that could set the version twice.
79%
#4083 requirements: update craft-parts to 1.19.0 snapcraft merged Merged PR #4083 (commit 0e2cf91be) bumped craft-parts to 1.19.0, adopting feature selection that makes the overlay step optional and improving dirty checks for plugin-specific property changes.
79%
#1021 requirements: update craft-parts to 1.18.1 charmcraft merged PR #1021 merged (commit e00cbd66, body commit 58669bb1), bumping craft-parts from 1.18.0 to 1.18.1 in requirements.txt and requirements-dev.txt to pick up the fix for ignored file patterns in local sources.
78%