← Back to issue list

store: correctly logout when credentials are invalid for legacy

View original Github issue

Metadata

Project
snapcraft
Number
#3921
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged fix for legacy credential handling that prevented logout when credentials were invalid. Changes stop credentials from being incorrectly loaded into the environment, resolving LP: #1980534.

Suggested action:

No scores available.

Issue body

There was a chance of not being able to logout when using legacy credentials as they got loaded into the environment regardless of what their origin was. LP: #1980534 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1297

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for legacy credential handling that prevented logout when credentials were invalid. Changes stop credentials from being incorrectly loaded into the environment, resolving LP: #1980534.
qwen3.6-35b-a3b-mtp-q6 Merged fix for logout failures with invalid legacy credentials. Updated credential loading logic to resolve environment pollution issues. Integrated into main as commit da1766c with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged fix for logout failures with invalid legacy credentials. Resolves LP #1980534 and CRAFT-1297 by ensuring proper credential handling. Integrated into main as commit da1766c.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3797 store: export-login with legacy snapcraft merged Merged to main. Resolves export-login to stop prioritizing legacy credentials during export. Approved, passed CI, and maintained 100% coverage.
71%