store: correctly logout when credentials are invalid for legacy
Metadata
Current evaluation
Merged #3921 at da1766c, fixing logout by loading legacy credentials from the environment only when they are valid.
Resolution: closed resolved
Reason: PR #3921 was merged into main at commit da1766c. It prevents invalid legacy credentials from being loaded into the environment, allowing logout to complete.
Evaluated by: mr-cal-bot
No scores available.
Issue body
There was a chance of not being able to logout when using legacy credentials as they got loaded into the environment regardless of what their origin was.
LP: #1980534
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1297
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3921 at da1766c, fixing logout by loading legacy credentials from the environment only when they are valid. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3921, correcting legacy credential handling so invalid or unknown-origin credentials no longer prevent logout. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for legacy credential handling that prevented logout when credentials were invalid. Changes stop credentials from being incorrectly loaded into the environment, resolving LP: #1980534. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for logout failures with invalid legacy credentials. Updated credential loading logic to resolve environment pollution issues. Integrated into main as commit da1766c with 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3797 store: export-login with legacy | snapcraft | merged | Merged PR #3797 as commit fbc65bb38, ensuring legacy credentials do not take precedence when exporting a store login. | |
| #1980534 Legacy credentials in Snapcraft 7 give a confusing error message | snapcraft (launchpad) | closed | Fixed legacy-credential logout handling in snapcore/snapcraft#3921 (commit c3d4c8999), allowing stale credentials to be cleared and login retried. | |
| #3794 store: full support for legacy login | snapcraft | merged | Merged PR #3794 via commit 86193a7b4 (7194ef18d), restoring legacy-login compatibility by using existing Snapcraft credentials to build craft-store authorization headers. |