← Back to issue list

store: export-login with legacy

View original Github issue

Metadata

Project
snapcraft
Number
#3797
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3797 as commit fbc65bb38, ensuring legacy credentials do not take precedence when exporting a store login.

Resolution: closed resolved

Reason: The approved change was merged into main via PR #3797 in commit fbc65bb38, resolving CRAFT-1146.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Existence of legacy credentials should not have preference when performing a login export. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1146

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3797 as commit fbc65bb38, ensuring legacy credentials do not take precedence when exporting a store login.
stealth/space-bunny-alpha — closed resolved Merged #3797 as fbc65bb38, changing store export-login to avoid preferring legacy credentials when exported credentials are available.
stealth/space-bunny-alpha — closed resolved PR #3797 (CRAFT-1146) merged as commit fbc65bb38; it stopped `store export-login` from preferring legacy credentials, preferring exported (candid) credentials when available.
stealth/space-bunny-alpha — closed resolved Merged as fbc65bb38 via #3797, export-login no longer prefers legacy credentials when exported credentials are available.
qwen/qwen3.6-35b-a3b — — Merged to main. Resolves export-login to stop prioritizing legacy credentials during export. Approved, passed CI, and maintained 100% coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Resolved CRAFT-1146 by updating store export-login logic to ignore legacy credentials preference. Achieved 100% diff coverage with no overall coverage impact.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3808 store: login requires no exported credentials snapcraft merged Merged into main as commit 7e6ef4514, updating store login so it no longer requires exported credentials for CRAFT-1148.
79%
#3794 store: full support for legacy login snapcraft merged Merged PR #3794 via commit 86193a7b4 (7194ef18d), restoring legacy-login compatibility by using existing Snapcraft credentials to build craft-store authorization headers.
77%
#3921 store: correctly logout when credentials are invalid for legacy snapcraft merged Merged #3921 at da1766c, fixing logout by loading legacy credentials from the environment only when they are valid.
77%