store: export-login with legacy
Metadata
Current evaluation
Merged to main. Resolves export-login to stop prioritizing legacy credentials during export. Approved, passed CI, and maintained 100% coverage.
Suggested action: —
No scores available.
Issue body
Existence of legacy credentials should not have preference
when performing a login export.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1146
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to main. Resolves export-login to stop prioritizing legacy credentials during export. Approved, passed CI, and maintained 100% coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Resolved CRAFT-1146 by updating store export-login logic to ignore legacy credentials preference. Achieved 100% diff coverage with no overall coverage impact. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Resolves CRAFT-1146 by updating export-login to ignore legacy credentials precedence. Achieved 100% diff coverage with no overall coverage impact. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3808 store: login requires no exported credentials | snapcraft | merged | Merged into main following reviewer approval and passing CI. The update modifies store login to require no exported credentials, changing 3 files (+29/-4 lines). Code coverage increased by 0.01% with 100% diff coverage. | |
| #3794 store: full support for legacy login | snapcraft | merged | Merged into main. Implements legacy login support via craft-store authorization while preserving backwards compatibility with prior Snapcraft credentials. Approved, passed CI, and achieved 100% test coverage. | |
| #3799 export-login: clarify use of exported tokens | snapcraft | merged | Merged clarification on exported token usage in export-login. Updated two files (+50/-3 lines). CI passed with 100% diff coverage. Unrelated upload failures and a minor coverage drop did not block the merge. | |
| #6302 fix: error when export-login target file already exists | snapcraft | merged | Fixes an internal error when running export-login twice to the same file. Currently under review with one approval and three unresolved comments. CI passes on most platforms but fails on Ubuntu 22.04/26.04 integration tests and security scans. | |
| #602 Added an export option to login to save the obtained credentials (CRAFT-641). | charmcraft | merged | Merged. Added an export option to the login command to save obtained credentials. Changes span 5 files with a +49/-7 line diff. The update depends on PR #601 and was approved by one reviewer prior to integration. | |
| #3921 store: correctly logout when credentials are invalid for legacy | snapcraft | merged | Merged fix for legacy credential handling that prevented logout when credentials were invalid. Changes stop credentials from being incorrectly loaded into the environment, resolving LP: #1980534. | |
| #3468 store: set auth headers when using login --with | snapcraft | merged | Merged into master after two approvals and passing CI. Adds 29 lines and removes 8 across three files to set auth headers for login --with. Diff coverage is 100% with no overall coverage impact. | |
| #1780 cli: add export-login command | snapcraft | merged | Merged the export-login CLI command and a --with flag for login to support CI systems. Review feedback updated packages to snaps and adjusted formatting. Approved and merged. | |
| #3789 store: support login --with | snapcraft | merged | Merged into main. Implements login --with support by restoring the legacy LegacyUbuntuOne and get_auth code paths from snapcraft 6.1 for backwards compatibility. Approved by reviewer and passed CI checks. |