lint: ignore snapd-testing-tools, venv
Metadata
Current evaluation
Merged linter configuration updates to ignore venv, snapd-testing-tools, and cache directories, resolving local development failures. Approved by reviewers, passed CI, and integrated into main.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Some minor fixes to the snapcraft linters that fail in a developer environment but not on CI (due to the dev environment having directories like `./build/`, `./venv/`, and submodules.
1. mypy - ignore `venv`
2. isort - ignore `snapd-testing-tools` and files in `.gitignore`
3. shellcheck - ignore `snapd-testing-tools` and `.ruff-cache`
4. Rename `spellcheck` to `spread-shellcheck`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged linter configuration updates to ignore venv, snapd-testing-tools, and cache directories, resolving local development failures. Approved by reviewers, passed CI, and integrated into main. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged linter config updates to ignore venv, snapd-testing-tools, and .ruff-cache, fixing local dev failures. Renamed spellcheck to spread-shellcheck. Merged into main with no coverage change. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to linter configurations to ignore local directories like venv and snapd-testing-tools, resolving local lint failures. Renamed spellcheck to spread-shellcheck. Code coverage unchanged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3936 lint: support the existence of 'venv' | snapcraft | closed | Merged into main. Added 'venv' to .gitignore and codespell skip list to prevent linting errors for common virtual environment directories. Approved by one reviewer with passing CI checks. | |
| #4101 lint: prepare instance for linting a snap file | snapcraft | merged | Merged into main. Updates snapcraft lint to prepare and re-execute inside a snap instance. Approved by a reviewer, passed CI, and increased coverage by 0.02%. Addresses CRAFT-1690. | |
| #4115 lint: lint snap files inside an instance | snapcraft | merged | Merged. Implements snapcraft lint execution inside a snap instance, covering unsquashing, metadata collection, installation, linting, and warning reporting. Approved, passed CI, achieved 100% diff coverage, and resolves CRAFT-1689. | |
| #3941 lint: support the existence of 'venv' | snapcraft | merged | Merged after reviewer approval and passing CI. Adds 'venv' and '.venv' to .gitignore and configures codespell to skip these common virtual environment directories. | |
| #196 lint: add shellcheck and spread-shellcheck linters | rockcraft | merged | Merged to add shellcheck and spread-shellcheck linters to the GitHub workflow. Includes minor compliance fixes. Approved by two reviewers with passing CI checks. Author inquired about documenting the shellcheck snap dependency. | |
| #77 lint: fix linting issues with up-to-date linters | craft-store | merged | Merged a maintainer-submitted pull request resolving linting errors from updated linter versions. Approved by one reviewer, passed CI, and modified 11 files (+40/-24 lines). |