commands: allow re-editing validation sets on error
Metadata
Current evaluation
Merged. Allows re-editing validation sets after rejection by extracting helper methods and adding a re-edit prompt loop. Approved by two reviewers with passing CI checks.
Suggested action: —
No scores available.
Issue body
Validation sets on error used to not provide a way to re-edit if the set
was rejected. Prompt the user if they want to re-edit the set after
showing the error.
The change here is the while loop, _generate_template and
_submit_validation_set have been extracted from the run method.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1388
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Allows re-editing validation sets after rejection by extracting helper methods and adding a re-edit prompt loop. Approved by two reviewers with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged: enables re-editing validation sets after rejection. Extracted template generation and submission logic into a loop that prompts users to correct and resubmit sets on error. Resolves CRAFT-1388. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enables re-editing validation sets after submission errors by extracting template generation and submission into a loop that prompts users to correct and resubmit rejected sets. Resolves CRAFT-1388. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3512 cli: introduce edit-validation-sets | snapcraft | merged | Merged the edit-validation-sets CLI command, enabling validation set editing. Based on the edit-collaborators implementation, the change received two approvals and added 322 lines across three files. |