commands: allow re-editing validation sets on error
Metadata
Current evaluation
Merged PR #3942 (commit e615f7a27) lets users re-edit rejected validation sets and refactors validation-set generation and submission helpers.
Resolution: closed resolved
Reason: PR #3942 was merged after approval. Commit e615f7a27 added a re-edit prompt following validation-set errors and extracted the related helper methods.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Validation sets on error used to not provide a way to re-edit if the set
was rejected. Prompt the user if they want to re-edit the set after
showing the error.
The change here is the while loop, _generate_template and
_submit_validation_set have been extracted from the run method.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1388
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3942 (commit e615f7a27) lets users re-edit rejected validation sets and refactors validation-set generation and submission helpers. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#3942 (e615f7a27), adding a re-edit prompt for rejected validation sets and extracting helper methods. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Allows re-editing validation sets after rejection by extracting helper methods and adding a re-edit prompt loop. Approved by two reviewers with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged: enables re-editing validation sets after rejection. Extracted template generation and submission logic into a loop that prompts users to correct and resubmit sets on error. Resolves CRAFT-1388. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4918 Test validation-set commands | snapcraft | closed | Added and merged spread tests for edit-validation-sets and list-validation-sets in PR #4924 (commit 157d0a182), resolving #4918. | |
| #6423 fix(validation-sets): don't validate new sets | snapcraft | closed | PR #6423 (SNAPCRAFT-1379) fixed edit-validation-sets rejecting brand-new validation sets at sequence 1; approved with no unresolved comments and landed as commit e7b47adb7, stacking on merged PR #6420. |