kernel plugin: do not copy extra-modules.conf
Metadata
Current evaluation
Merged to stop copying a missing extra-modules.conf, then reverted by #3998 because it dropped configured initramfs modules; #3998 instead ensured an empty file was always created.
Resolution: closed superseded
Reason: PR #3973 merged, but maintainer @kubiko identified a regression and said it would be reverted in #3998. Merged #3998 restored module handling by always creating an empty configuration file.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes failure to copy due to non-existent source file. Source file no longer exists upstream, and intended target already exists. See https://github.com/snapcore/core-initrd/tree/main/modules
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Merged to stop copying a missing extra-modules.conf, then reverted by #3998 because it dropped configured initramfs modules; #3998 instead ensured an empty file was always created. | |
| stealth/space-bunny-alpha | — | closed not a bug | Merged in #3973, then reverted by #3998 because it excluded configured initramfs modules; #3998 restored handling by always creating an empty module list. | |
| stealth/space-bunny-alpha | — | closed superseded | Merged in #3973 to avoid copying a nonexistent extra-modules.conf, but the change excluded configured initramfs modules and was reverted by #3998; always creating an empty file was preferred. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to fix a missing source file error, but caused a regression excluding defined kernel modules. Reverted in PR #3998; the correct resolution requires always creating an empty configuration file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to fix a missing file copy error, but reverted in PR #3998 due to a regression blocking kernel modules. Superseded; the correct fix is to always create an empty file instead of skipping the copy. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#3998
(confidence 100%)
#3998 reverted this change and implemented the corrected empty-file behavior.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #837 kernel plugin: allow collecting the same mod deps | snapcraft | merged | Merged PR #837 in commit 2e9e4b667, deduplicating kernel-module dependencies with a set so shared dependencies are not copied twice into the initrd. | |
| #476 kernel plugin: iterate over modules to add to initrd | snapcraft | merged | Kernel plugin now iterates over required modules when assembling the initrd; PR #476 was merged as commit 53941d2b0, resolving LP #1572118. | |
| #4057 Kernel plugin: reapplying missed fixes | snapcraft | merged | Merged PR #4057 fixed kernel-plugin initramfs handling for empty module lists, wildcard overlays, and UC20 module installation, clarified defaults, and updated tests. |