← Back to issue list

Testing: Lint and test using Tox

View original Github issue

Metadata

Project
snapcraft
Number
#4005
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4005 (4526909), adding Tox-based linting and unit-test GitHub Actions while retaining legacy checks for comparison.

Resolution: closed resolved

Reason: PR #4005 was merged with commit 4526909, adding Tox lint and test configuration plus a GitHub Actions workflow for CRAFT-1513. Two reviewers approved the change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Configures tox for linting and unit testing and provides a GitHub workflow for running Tox. Does not disable old linting and testing yet for the sake of comparison. (CRAFT-1513)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4005 (4526909), adding Tox-based linting and unit-test GitHub Actions while retaining legacy checks for comparison.
stealth/space-bunny-alpha — closed resolved Merged as commit 5e14f6de6, adding Tox-based linting and unit testing with a GitHub Actions workflow while retaining legacy checks for comparison.
stealth/space-bunny-alpha — closed resolved Merged PR #4005 (4526909), adding Tox-based linting and unit testing with a GitHub Actions workflow while retaining legacy checks for comparison.
stealth/space-bunny-alpha — closed resolved Merged PR #4005 (commit 5e14f6de6) added Tox-based linting and unit tests plus a GitHub Actions workflow, keeping legacy checks temporarily for comparison.
stealth/space-bunny-alpha — closed resolved Merged #4005 in commit 5e14f6de6, configuring Tox for linting and unit tests and adding a GitHub Actions workflow; legacy checks remained temporarily.
stealth/space-bunny-alpha — closed resolved Merged #4005, adding Tox-based lint and unit testing plus a GitHub Actions workflow; legacy checks remained temporarily for comparison. Coverage was unchanged.
qwen/qwen3.6-35b-a3b — — Merged after two approvals and passing CI. Configured Tox for linting and unit testing with a new GitHub Actions workflow. Legacy testing remains temporarily for comparison. Code coverage unchanged.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main, configuring Tox for linting and unit testing with a new GitHub workflow. Legacy testing remains temporarily for comparison. Code coverage unchanged upon merge.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4018 (confidence 85%)

    Follow-up PR removed the legacy non-Tox tests and linting initially retained for comparison.

Related issues

Issue Project State Summary Similarity
#4018 Remove non-tox CI tests and linting snapcraft merged Merged #4018 as commit 88fbd5b71, deleting 90 lines of redundant non-tox CI test and lint jobs from .github/workflows/tests.yaml after tox-based checks landed in #4005.
76%
#4058 tox: fix linters and makefile snapcraft merged PR #4058 by lengau merged as commit be5d4307 ("tox: fix linters and makefile"), correcting linter config in tox.ini and the Makefile after the starbase tox migration (#4046). Codecov reported no coverage change.
75%
#332 tox: improve UX for testing craft-providers merged Merged PR #332 as commit 38739ea, updating tox configuration to improve the local testing experience.
72%
#616 build: use tox for unit tests in CI craft-parts merged Merged PR #616 switched unit-test CI to tox; it was approved by two reviewers and landed as commit bd6c687f.
71%
#107 ci: separate unit and integration tests starbase merged Merged PR #107 as commit 3244cc2, splitting the GitHub Actions test workflow into separate unit and integration test jobs; repo now has tests/unit and tests/integration trees plus a test-integration tox env.
70%
#473 feat(lint): lint the Github actions with actionlint starbase merged Merged PR #473 in commit e385e9d, adding actionlint-based linting for GitHub Actions workflows to the shared build tooling.
70%