← Back to issue list

Remove non-tox CI tests and linting

View original Github issue

Metadata

Project
snapcraft
Number
#4018
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged to remove non-tox CI tests and linting. The change deleted 90 lines in one file, was approved by a reviewer, passed CI checks, and resulted in zero coverage change per Codecov.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to remove non-tox CI tests and linting. The change deleted 90 lines in one file, was approved by a reviewer, passed CI checks, and resulted in zero coverage change per Codecov.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Removes non-tox CI tests and linting to streamline the pipeline. Codecov confirms no change in overall code coverage after integration.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Removes non-tox CI tests and linting configurations. Codecov reports zero coverage impact upon integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#461 test: improve test coverage fetch-service merged Merged to improve test coverage, adding 270 lines across three files. Approved by two reviewers with all CI checks passing.
77%
#33 Linting imagecraft merged Merged a one-line linting fix from a maintainer. The change modified a single file with one addition and one deletion, requiring no reviews or CI checks before integration.
75%
#458 test: improve test coverage fetch-service merged Merged after approval from two reviewers and passing CI checks. Added 370 lines of test code across five files to improve overall test coverage.
75%
#278 tests: additional tests to improve coverage fetch-service merged Merged after two reviews and passing CI checks. Adds additional tests across ten files to improve code coverage, changing +386/-60 lines.
74%
#616 build: use tox for unit tests in CI craft-parts merged Merged. CI configuration updated to use tox for unit tests. Approved by two reviewers with passing checks. Modified two files (+66/-10).
74%
#4036 tests: ensure coverage is set per tox env snapcraft merged Merged a single-file change (+3/-2 lines) to set test coverage per tox environment. Approved by a reviewer, passed CI, and integrated without changing coverage metrics.
73%
#36 Lint imagecraft merged Merged a single-file linting adjustment with one addition and one deletion. The maintainer-submitted change required no reviews or CI checks before integration.
73%
#56 Issues/44 refactor rockcraft merged Merged two small refactorings approved by one reviewer with zero unresolved comments. CI checks passed. Changes modified two files, adding 28 and removing 25 lines.
73%
#4005 Testing: Lint and test using Tox snapcraft merged Merged after two approvals and passing CI. Configured Tox for linting and unit testing with a new GitHub Actions workflow. Legacy testing remains temporarily for comparison. Code coverage unchanged.
73%
#118 style: remove pylint craft-store merged Merged to remove pylint from the project. Approved by one reviewer, passed CI checks, and modified two files with a net reduction of three lines.
72%