← Back to issue list

Remove non-tox CI tests and linting

View original Github issue

Metadata

Project
snapcraft
Number
#4018
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4018 as commit 88fbd5b71, deleting 90 lines of redundant non-tox CI test and lint jobs from .github/workflows/tests.yaml after tox-based checks landed in #4005.

Resolution: closed resolved

Reason: The PR was merged by maintainer lengau with one approving review, resolving in commit 88fbd5b71 ("ci: remove non-tox tests and linting (#4018)"), which touched a single file (.github/workflows/tests.yaml) with -90/+0 lines. It was the cleanup follow-up to commit 5e14f6de6 (#4005), which had introduced tox-based linting and unit tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4018 as commit 88fbd5b71, deleting 90 lines of redundant non-tox CI test and lint jobs from .github/workflows/tests.yaml after tox-based checks landed in #4005.
stealth/space-bunny-alpha — closed resolved Merged #4018, removing 90 lines of non-tox CI test and lint jobs in commit 88fbd5b71.
qwen/qwen3.6-35b-a3b — — Merged to remove non-tox CI tests and linting. The change deleted 90 lines in one file, was approved by a reviewer, passed CI checks, and resulted in zero coverage change per Codecov.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Removes non-tox CI tests and linting to streamline the pipeline. Codecov confirms no change in overall code coverage after integration.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4005 (confidence 95%)

    Preceding merged PR 5e14f6de6 added tox-based linting and unit test jobs, which is why the duplicated non-tox jobs in tests.yaml were safe to delete in #4018.

Related issues

Issue Project State Summary Similarity
#4005 Testing: Lint and test using Tox snapcraft merged Merged PR #4005 (4526909), adding Tox-based linting and unit-test GitHub Actions while retaining legacy checks for comparison.
76%
#1331 test: remove black linting from test_infra charmcraft merged Merged #1331 as d3afd159, removing 13 lines of Black linting from test_infra; tox now handles linting for CRAFT-2143.
72%
#4058 tox: fix linters and makefile snapcraft merged PR #4058 by lengau merged as commit be5d4307 ("tox: fix linters and makefile"), correcting linter config in tox.ini and the Makefile after the starbase tox migration (#4046). Codecov reported no coverage change.
70%
#4435 ci: colorize tox and collapse sections snapcraft merged Merged PR #4435 (commit 77ac1119b) added tox-gh to collapse CI log sections and colorize tox output, replacing draft PR #4422. Approved by 2 reviewers.
70%