Properly validate the schema
Metadata
Current evaluation
Merged refactoring that consolidates schema validation logic and removes it from snapcraft.yaml. The changes were finalized after fixing failing autopackage tests and addressing reviewer feedback.
Suggested action: —
No scores available.
Issue body
There's a refactor to not duplicate work and to also move stuff out of
`snapcraft.yaml`
LP: #1564607
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that consolidates schema validation logic and removes it from snapcraft.yaml. The changes were finalized after fixing failing autopackage tests and addressing reviewer feedback. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a schema validation refactor that eliminates duplication and moves logic out of snapcraft.yaml. After addressing test and autopackage failures during review, the maintainer fixed the tests and completed the merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor that properly validates the schema by removing duplication and moving logic out of snapcraft.yaml. Failing autopackage and unit tests were fixed prior to final merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3526 project: validate snapcraft yaml before using it (CRAFT-55) | snapcraft | closed | Merged into master. Moves snapcraft YAML validation to get_project() to prevent errors during extension application and JSON schema checks. Approved by two reviewers. | |
| #1615 schema: improve invalid app, hook, and part errors | snapcraft | merged | Merged changes improve validation error messages for invalid app, hook, and part names in snapcraft.yaml. Replaces confusing jsonschema errors with custom validation messages, resolving Launchpad bug #1606890. Approved by two reviewers and passed CI. | |
| #2627 synchronizing snapd supported schema to snapcraft | snapcraft | merged | Merged. Synchronized snapd schema with snapcraft, adding dbus daemon type, bus-name, restart-delay, and updated regex patterns. Approved by reviewers after clarifying autostart file validation and finalizing schema updates. | |
| #5924 docs: clean up 'snapcraft.yaml' | snapcraft | merged | Merged documentation cleanup for snapcraft.yaml, including typo fixes, docstring link updates, and JSON schema regeneration. Reviewers approved the non-functional changes, and the schema workflow was resolved by running make schema. |