Properly validate the schema
Metadata
Current evaluation
Merged PR #419 in commit 116352b7d, refactoring schema validation to remove duplicated logic from snapcraft.yaml and fixing autopackage tests.
Resolution: closed resolved
Reason: PR #419 was merged as commit 116352b7d after the autopackage-test issue and a test were fixed. The implementation addresses Launchpad bug #1564607.
Evaluated by: mr-cal-bot
No scores available.
Issue body
There's a refactor to not duplicate work and to also move stuff out of
`snapcraft.yaml`
LP: #1564607
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #419 in commit 116352b7d, refactoring schema validation to remove duplicated logic from snapcraft.yaml and fixing autopackage tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged schema-validation refactor that removed duplicated work and moved logic out of snapcraft.yaml; merged as commit 116352b7d. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #419 in commit 116352b7d, refactoring schema validation to remove duplicated logic from snapcraft.yaml; autopackage test issues and a test were fixed. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that consolidates schema validation logic and removes it from snapcraft.yaml. The changes were finalized after fixing failing autopackage tests and addressing reviewer feedback. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a schema validation refactor that eliminates duplication and moves logic out of snapcraft.yaml. After addressing test and autopackage failures during review, the maintainer fixed the tests and completed the merge. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
snapcraft (launchpad)#1564607
(confidence 95%)
Launchpad bug explicitly linked in PR #419 as the motivating issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1806055 Snapcraft schema validation with bases | snapcraft (launchpad) | closed | Fixed by snapcore/snapcraft#2473, merged as 3f7d63cdf, which improved Go/Python plugin schema validation and covered no-op part configurations. | |
| #2446 Update schema/snapcraft.yaml | snapcraft | closed | PR #2446 edited schema/snapcraft.yaml to aid yaml-to-json converters but was closed unmerged in favour of #2448, which replaced the YAML schema with snapcraft.json (commit 2a2f798d0). | |
| #5140 Add lint to schema | snapcraft | closed | Lint support was added to snapcraft.yaml schemas, fixing editor errors and missing autocomplete via merged PR #5730 (commit 7cfb25977). | |
| #296 Improve snapcraft.yaml validation errors. | snapcraft | merged | Merged in snapcraft#296 via commit 452a91595, improving errors for missing icons, AppArmor/seccomp files, and schema properties; fixes LP #1524663. | |
| #2627 synchronizing snapd supported schema to snapcraft | snapcraft | merged | Merged in snapcore/snapcraft#2627 (5534fe3d), synchronizing Snapcraft’s schema with snapd’s supported daemon and app fields and validation patterns. | |
| #5730 feat: add inheritance-based validation and schemas | snapcraft | merged | Merged as commit 7cfb25977, adding inheritance-based pydantic validation and JSON schema generation (tools/schema.py, snapcraft/models/project.py) for snapcraft.yaml, closing issue #5543. | |
| #2448 Swap yaml schema document with json equivalent | snapcraft | merged | PR #2448 merged as commit 2a2f798d0 ("schema: convert yaml jsonschema document to a json equivalent"), replacing schema/snapcraft.yaml with schema/snapcraft.json and adjusting validation error formatting. |