← Back to issue list

Update schema/snapcraft.yaml

View original Github issue

Metadata

Project
snapcraft
Number
#2446
Type
pull request
State
closed
Author
lucyllewy
Labels
Created
Updated
Closed

Current evaluation

Superseded by pull request #2448. The schema/snapcraft.yaml update for YAML-to-JSON compatibility was closed without merging after reviewer feedback on Python test string handling and the decision to address the change in a replacement pull request.

Suggested action:

No scores available.

Issue body

Improve compatibility with yaml to json converters Signed-off-by: Daniel Llewellyn <daniel@bowlhat.net> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Superseded by pull request #2448. The schema/snapcraft.yaml update for YAML-to-JSON compatibility was closed without merging after reviewer feedback on Python test string handling and the decision to address the change in a replacement pull request.
qwen3.6-35b-a3b-mtp-q6 Superseded by pull request #2448. The schema update improved YAML to JSON converter compatibility. After author corrections and test feedback, the changes were consolidated into the referenced PR.
qwen3.6-35b-a3b-mtp-q6 Superseded by PR #2448. After an initial error and fix, the PR encountered failing Python tests. The maintainer closed it to consolidate changes into the newer pull request.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5924 docs: clean up 'snapcraft.yaml' snapcraft merged Merged documentation cleanup for snapcraft.yaml, including typo fixes, docstring link updates, and JSON schema regeneration. Reviewers approved the non-functional changes, and the schema workflow was resolved by running make schema.
76%
#2448 Swap yaml schema document with json equivalent snapcraft merged Merged conversion of the snapcraft YAML schema to JSON. Reviewers requested formatting adjustments for validation error messages, specifically removing line breaks and using echo.wrap. Approved, passed CI, and merged to master.
72%
#146 Syntax of snapcraft.yaml (1.x) snapcraft merged Merged after rebasing to resolve diff conflicts and squashing commits. The pull request updates snapcraft.yaml (1.x) syntax and received final approval before integration.
71%