← Back to issue list

Update schema/snapcraft.yaml

View original Github issue

Metadata

Project
snapcraft
Number
#2446
Type
pull request
State
closed
Author
lucyllewy
Labels
—
Created
Updated
Closed

Current evaluation

PR #2446 edited schema/snapcraft.yaml to aid yaml-to-json converters but was closed unmerged in favour of #2448, which replaced the YAML schema with snapcraft.json (commit 2a2f798d0).

Resolution: closed superseded

Reason: Maintainer sergiusens closed it explicitly 'in favour of #2448' after 3 unresolved review comments, rather than merging the YAML tweaks. #2448 took the same goal (better yaml/json converter compatibility) by converting the schema document to JSON, and landed as commit 2a2f798d0 ('schema: convert yaml jsonschema document to a json equivalent').

Evaluated by: mr-cal-bot

No scores available.

Issue body

Improve compatibility with yaml to json converters Signed-off-by: Daniel Llewellyn <daniel@bowlhat.net> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #2446 edited schema/snapcraft.yaml to aid yaml-to-json converters but was closed unmerged in favour of #2448, which replaced the YAML schema with snapcraft.json (commit 2a2f798d0).
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of canonical/snapcraft#2448, which replaced the schema YAML with JSON and was merged into master.
qwen/qwen3.6-35b-a3b — — Superseded by pull request #2448. The schema/snapcraft.yaml update for YAML-to-JSON compatibility was closed without merging after reviewer feedback on Python test string handling and the decision to address the change in a replacement pull request.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by pull request #2448. The schema update improved YAML to JSON converter compatibility. After author corrections and test feedback, the changes were consolidated into the referenced PR.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#2448 (confidence 98%)

    Named by the closing comment as the replacement; merged as commit 2a2f798d0 and the schema/ directory now contains a single JSON schema file.

  • Likely Fixed By: canonical/snapcraft#2448 (confidence 95%)

    Same underlying goal (yaml-to-json converter compatibility) achieved by replacing schema/snapcraft.yaml with a JSON equivalent.

Related issues

Issue Project State Summary Similarity
#2448 Swap yaml schema document with json equivalent snapcraft merged PR #2448 merged as commit 2a2f798d0 ("schema: convert yaml jsonschema document to a json equivalent"), replacing schema/snapcraft.yaml with schema/snapcraft.json and adjusting validation error formatting.
81%
#5744 Migrate legacy schema snapcraft closed Migrated the legacy schema to snapcraft-legacy.json and updated snapcraft_legacy to use the copy; merged in #5751 (cf2ecd9dc).
73%
#1815062 Export the schema to json to allow for easier IDE linting snapcraft (launchpad) closed Exported the Snapcraft schema as JSON for IDE and jsonschema linting via canonical/snapcraft#2448, merged in commit 2a2f798d0.
73%
#419 Properly validate the schema snapcraft merged Merged PR #419 in commit 116352b7d, refactoring schema validation to remove duplicated logic from snapcraft.yaml and fixing autopackage tests.
73%
#146 Syntax of snapcraft.yaml (1.x) snapcraft merged PR #146 was merged, updating the snapcraft.yaml 1.x syntax reference after review, rebase, and squash; it built on merged PR #131.
71%
#5472 Refactor YAML Generation and Schema Models for Optional Summary Support snapcraft closed Closed unmerged and superseded by canonical/snapcraft#5501 (commit 9d7a82a19), which added optional confdb-schema summary fields and tests for issue #5442.
71%
#3812 architectures: add schema support snapcraft merged Merged as commit 629e4ce51: adds core22 architectures schema support to snapcraft.yaml (build_to renamed to build_for), part 1 of CRAFT-1163; full feature followed in #3821 (4876b53).
70%
#5140 Add lint to schema snapcraft closed Lint support was added to snapcraft.yaml schemas, fixing editor errors and missing autocomplete via merged PR #5730 (commit 7cfb25977).
70%
#1622 schema: sync patterns with snapd snapcraft merged Merged PR #1622 in commit 066d6e757, aligning snap and hook name schema patterns with snapd and improving jsonschema error handling; fixes LP #1693798.
70%