← Back to issue list

Swap yaml schema document with json equivalent

View original Github issue

Metadata

Project
snapcraft
Number
#2448
Type
pull request
State
merged
Author
lucyllewy
Labels
Created
Updated
Closed

Current evaluation

Merged conversion of the snapcraft YAML schema to JSON. Reviewers requested formatting adjustments for validation error messages, specifically removing line breaks and using echo.wrap. Approved, passed CI, and merged to master.

Suggested action:

No scores available.

Issue body

Direct conversion of schema/snapcraft.yaml to json saved to schema/snapcraft.json. Signed-off-by: Daniel Llewellyn <daniel@bowlhat.net> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? Unit tests fail on the formatting of messages regarding yaml validation -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged conversion of the snapcraft YAML schema to JSON. Reviewers requested formatting adjustments for validation error messages, specifically removing line breaks and using echo.wrap. Approved, passed CI, and merged to master.
qwen3.6-35b-a3b-mtp-q6 Merged conversion of the snapcraft schema from YAML to JSON. Feedback led to removing embedded line breaks and updating error printing to echo.wrap, resolving unit test failures. The change increased code coverage by 0.01%.
qwen3.6-35b-a3b-mtp-q6 Merged into master after converting the snapcraft.yaml schema to JSON. Review feedback on error message formatting was addressed. The change passed coverage checks and successfully replaced the YAML schema with a JSON equivalent.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5924 docs: clean up 'snapcraft.yaml' snapcraft merged Merged documentation cleanup for snapcraft.yaml, including typo fixes, docstring link updates, and JSON schema regeneration. Reviewers approved the non-functional changes, and the schema workflow was resolved by running make schema.
75%
#2446 Update schema/snapcraft.yaml snapcraft closed Superseded by pull request #2448. The schema/snapcraft.yaml update for YAML-to-JSON compatibility was closed without merging after reviewer feedback on Python test string handling and the decision to address the change in a replacement pull request.
72%
#3526 project: validate snapcraft yaml before using it (CRAFT-55) snapcraft closed Merged into master. Moves snapcraft YAML validation to get_project() to prevent errors during extension application and JSON schema checks. Approved by two reviewers.
71%