← Back to issue list

extensions: support for content sharing for ROS

View original Github issue

Metadata

Project
snapcraft
Number
#4221
Type
pull request
State
merged
Author
artivis
Labels
—
Created
Updated
Closed

Current evaluation

Merged in 374c5c6a6, adding ROS content-sharing support and ROS extensions/plugins for core20/core22 (Noetic, Foxy, and Humble).

Resolution: closed resolved

Reason: PR #4221 was squash-merged as commit 374c5c6a6 after approval, delivering ROS content-sharing extensions and plugin support across core20 and core22.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR introduces the support of content sharing for ROS together with a few extensions that make building a ROS content sharing snap seamless. To that effect several snaps meant to distribute ROS through content-sharing were created and are available on the store (hidden, e.g. [`ros-foxy-ros-base`](https://snapcraft.io/ros-foxy-ros-base) & [`ros-foxy-ros-base-dev`](ros-foxy-ros-base-dev)) This PR is large as it concerns, - core20 & 22 (ROS Noetic, Foxy, Humble) - colcon, catkin, catkin-tools plugins To note: - requires the 'dev' snap providing the build-time material to execute a script listing all ROS packages it contains when it's built - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in 374c5c6a6, adding ROS content-sharing support and ROS extensions/plugins for core20/core22 (Noetic, Foxy, and Humble).
stealth/space-bunny-alpha — closed resolved Merged in 374c5c6a6, adding ROS content-sharing support and ROS extensions/plugins for core20 and core22 (Noetic, Foxy, and Humble).
qwen/qwen3.6-35b-a3b — — Merged Sept 14, 2023. Adds ROS content sharing support and snapcraft extensions for core20/22 and colcon/catkin. Rebased onto main and PR #4271, then squash-merged after dual approval. One test disabled due to conflicts.
qwen3.6-35b-a3b-mtp-q6 — — Merged following maintainer approvals. Squash-merged after rebasing on main and PR #4271. Introduces ROS content sharing support and build extensions for core20/22, including colcon and catkin plugins.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4271 (confidence 100%)

    PR #4271 supplied plugin-aware extension support and was merged before #4221 was rebased onto it.

Related issues

Issue Project State Summary Similarity
#4828 Add ROS 2 Jazzy content-sharing support snapcraft merged Merged as commit b0880a028 ("feat(extensions): content sharing for ROS 2 Jazzy"), adding the ros2-jazzy-ros-base content extension following #4791. Follow-up #4940 later added arm64 test coverage.
74%
#4180 Feature/ros content sharing snapcraft closed Closed unmerged after inactivity; ROS content-sharing support was delivered by merged PR #4221 in commit 374c5c6a6.
73%
#6139 fix: ros content sharing non upstream package 8 14 snapcraft merged Merged in commit 0833c6d21, fixing ROS 2 content sharing for non-upstream dependencies and replacing deprecated rospack with ros2 pkg; supersedes #6120.
71%