← Back to issue list

spread: separate legacy tests

View original Github issue

Metadata

Project
snapcraft
Number
#4247
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed PR #4247 was superseded by merged PR #4248, which split legacy spread tests into separate GitHub Actions runs to reduce repeated work after failures.

Resolution: closed superseded

Reason: PR #4248 was merged into main and implemented the legacy spread-test split in separate GitHub Actions runs. That merged replacement delivered the behavior sought by PR #4247.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The primary purpose of this is to place the tests into separate GitHub Actions runs, reducing the repeated test runs if a test fails. A little Python script reading the GHA logs reveals that the following groups of tests take the longest (in worker time, not actual time): 1. `plugins/v2/` (12443 s) 2. `providers/legacy/` (2942 s) 3. `plugins/craft-parts/` (2659 s) 4. `general/package-repositories/` (1181 s) 5. `general/pack/` (1044 s) The total time of the 20.04 runs is about 22000 s, so this splits the 20.04 run roughly in half, with the group that's likely to expand in time currently being smaller. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed PR #4247 was superseded by merged PR #4248, which split legacy spread tests into separate GitHub Actions runs to reduce repeated work after failures.
stealth/space-bunny-alpha — closed resolved PR #4248 was merged into main, splitting legacy spread tests into separate GitHub Actions runs to reduce redundant test execution after failures.
qwen/qwen3.6-35b-a3b — — Merged changes to split legacy spread tests into separate GitHub Actions workflows, reducing redundant execution time and improving CI efficiency.
qwen3.6-35b-a3b-mtp-q6 — — Merged to separate legacy spread tests into distinct GitHub Actions workflows, reducing CI retry overhead by parallelizing execution of slow test groups.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#4248 (confidence 95%)

    Merged replacement implementing the same split of legacy spread tests.

Related issues

Issue Project State Summary Similarity
#4248 spread: separate legacy tests snapcraft closed PR #4248 was merged into main, separating legacy spread tests into dedicated GitHub Actions runs to reduce repeated test execution after failures.
96%
#3374 [wip] ci: migrate spread tests to github actions snapcraft closed WIP PR to migrate spread tests from Travis CI to GitHub Actions, closed unmerged. Superseded by PR #3375, merged as commit 6c59e9f55 with the identical +84/-6, 3-file change.
76%
#2276 spread: move legacy wiki tests to spread snapcraft merged Merged PR #2276 as commit 806b0b0db, moving all non-fake-server legacy wiki tests from the general integration suite to Spread.
76%
#3432 spread tests: remove legacy plugin tests snapcraft merged PR #3432 (commit 950fa2508, f2c9caa04) merged: deleted 665 lines of legacy plugin spread tests across 29 files, removing outdated plugin coverage without affecting code coverage (90.83%).
74%
#3375 ci: migrate spread tests to github actions snapcraft merged Merged #3375 moved spread tests from Travis CI to GitHub Actions, updating three CI files (+84/-6).
71%
#3966 Spread multipass tests snapcraft merged Merged #3966 as f787c56fe, moving manual Multipass Spread tests out of the legacy test directory while noting they cannot run on Google infrastructure.
71%
#895 ci: move prometheus test to spread charmcraft merged PR #895 moved the Prometheus test from GitHub Actions to Spread and was merged via 5487dfe6; implementation commit eb4b47b9.
70%
#3089 ci: move staging store tests to spread snapcraft closed Superseded by merged PR #3090, which moved staging store tests to Spread in commit 3a037fb11.
70%