spread: separate legacy tests
Metadata
Current evaluation
Merged into main. The pull request separated legacy spread tests into dedicated GitHub Actions workflows to reduce redundant CI execution time and improve pipeline efficiency.
Suggested action: —
No scores available.
Issue body
The primary purpose of this is to place the tests into separate GitHub Actions runs, reducing the repeated test runs if a test fails.
A little Python script reading the GHA logs reveals that the following groups of tests take the longest (in worker time, not actual time):
1. `plugins/v2/` (12443 s)
2. `providers/legacy/` (2942 s)
3. `plugins/craft-parts/` (2659 s)
4. `general/package-repositories/` (1181 s)
5. `general/pack/` (1044 s)
The total time of the 20.04 runs is about 22000 s, so this splits the 20.04 run roughly in half, with the group that's likely to expand in time currently being smaller.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. The pull request separated legacy spread tests into dedicated GitHub Actions workflows to reduce redundant CI execution time and improve pipeline efficiency. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Splits legacy spread tests into separate GitHub Actions workflows to reduce CI runtime and retry overhead. Codecov reported a 0.01% coverage increase upon integration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Separates legacy spread tests into distinct GitHub Actions workflows to optimize CI runtime and minimize redundant failures. Increases repository coverage by 0.01%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4247 spread: separate legacy tests | snapcraft | closed | Merged changes to split legacy spread tests into separate GitHub Actions workflows, reducing redundant execution time and improving CI efficiency. | |
| #2276 spread: move legacy wiki tests to spread | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated legacy wiki tests from integration tests to spread, updating 12 files with a net reduction of 42 lines. Addresses LP: #1792717. | |
| #3966 Spread multipass tests | snapcraft | merged | Merged a minor refactor moving manual multipass tests out of the legacy directory. An unrelated spread test failure was noted and resolved by a separate pull request. | |
| #3432 spread tests: remove legacy plugin tests | snapcraft | merged | Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR. | |
| #3375 ci: migrate spread tests to github actions | snapcraft | merged | Merged to master after approval. Migrated spread tests to GitHub Actions, modifying three files with 84 additions and 6 deletions. Codecov reported a negligible 0.01% coverage decrease. | |
| #665 Start using `spread` for integration tests | charmcraft | closed | Completed and merged via pull request #862, which implemented the spread infrastructure and added integration tests. The issue was closed after the changes were successfully integrated. | |
| #3540 spread tests: remove 16.04 and core (CRAFT-210) | snapcraft | merged | Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations. | |
| #3374 [wip] ci: migrate spread tests to github actions | snapcraft | closed | Marked as WIP, the pull request to migrate spread tests to GitHub Actions was closed without review or merge. No CI checks ran and no reviewers were assigned, indicating the work was abandoned. | |
| #592 feat(testing): execute spread on generated file | craft-application | merged | Merged after approval. Updates the testing workflow to execute spread on a generated temporary file with a resolved testing backend. Unrelated integration test failures were addressed in a separate pull request. | |
| #519 spread: reorganize spread tests | rockcraft | merged | Merged via squash-merge. Reorganizes spread tests to optimize CI resource usage by consolidating most tests into a jammy-based rockcraft suite and adding a foreign suite for cross-system testing. Changes affect 73 files. |