← Back to issue list

chore: rename remote-build test

View original Github issue

Metadata

Project
snapcraft
Number
#4383
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged a code cleanup that renamed the test module to match the source file remote.py. Approved by two reviewers, passed CI checks, and successfully integrated into the main branch.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- Pedantic change: the name of the module and test should match. `snapcraft/commands/remote.py` => `tests/unit/commands/test_remote.py`

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a code cleanup that renamed the test module to match the source file remote.py. Approved by two reviewers, passed CI checks, and successfully integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 Merged a chore to rename the remote-build test module to test_remote.py, aligning it with snapcraft/commands/remote.py. The change passed all linting and unit tests.
qwen3.6-35b-a3b-mtp-q6 Merged a chore renaming the remote-build test to test_remote.py, aligning it with the source file remote.py. Linting and unit tests passed successfully.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6010 chore!: remove remote-build service override snapcraft merged Merged cleanup removing the remote-build service override and manual spread tests. This follow-up addresses overlooked work from PR #5994. Approved by two reviewers, modifying seven files.
79%
#5390 chore(remotebuild): use new build planner snapcraft merged Merged remote build updates to adopt the new get_launchpad_build_plan() and remove unit test xfails. Approved by two reviewers, passed CI checks, and integrated.
78%
#5994 chore!: remove legacy remote builder snapcraft merged Merged changes removing the legacy remote builder, resolving issue #5676. Approved by three reviewers and passing CI checks. The update deletes 3,200 lines across 30 files to clean up deprecated build infrastructure.
75%
#2682 chore: delete some dead code charmcraft open Removes 19 lines of dead code in one file, a follow-up to #2681 (remote-build project name fix). Approved by a maintainer, CI mostly green with a few failing/pending snap tests.
74%
#4660 refactor(test): versioned remote-build tests snapcraft merged Merged test refactoring for versioned remote-build tests with no logic changes. Approved by two reviewers, zero unresolved comments, and passing CI. Codecov confirmed full coverage on modified lines. Successfully integrated.
73%
#4549 chore(merge): rebase on origin/main snapcraft merged Merged after rebasing feature/craft-application onto origin/main. Approved by two reviewers, title corrected, and tests passed. Completes the first step of the planned branch integration sequence.
72%
#5540 chore: resolve deprecation warnings snapcraft merged Merged to resolve deprecation warnings before they become errors. Updates test mocking context manager setup. Approved by two reviewers and merged despite one failing integration test. Closes #5539.
71%
#636 chore(ci): move base devel spread tests to manual rockcraft merged Merged CI changes repurposing the large spread test run into a manual cron job. This isolates flaky base devel tests while preserving visibility via scheduled execution. Approved by two reviewers and applied across six files.
70%