← Back to issue list

chore: rename remote-build test

View original Github issue

Metadata

Project
snapcraft
Number
#4383
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4383 (commit 4f7f4a58a) renamed tests/unit/commands/test_remote_build.py to test_remote.py so the test module name matches snapcraft/commands/remote.py. Pure rename, no functional change.

Resolution: closed resolved

Reason: The PR was merged into master as commit 4f7f4a58a ("chore: rename remote-build test (#4383)"), with approved reviews and no unresolved comments; subsequent history shows tests/unit/commands/test_remote.py tracked from that commit onward.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- Pedantic change: the name of the module and test should match. `snapcraft/commands/remote.py` => `tests/unit/commands/test_remote.py`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4383 (commit 4f7f4a58a) renamed tests/unit/commands/test_remote_build.py to test_remote.py so the test module name matches snapcraft/commands/remote.py. Pure rename, no functional change.
stealth/space-bunny-alpha — closed resolved Merged PR #4383 (commit 4f7f4a58a) renamed the remote-build unit test module to tests/unit/commands/test_remote.py so it matches snapcraft/commands/remote.py; pure chore, approved by 2 reviewers.
stealth/space-bunny-alpha — closed resolved Merged PR #4383 renamed the remote-build unit test module to test_remote.py, matching remote.py.
qwen/qwen3.6-35b-a3b — — Merged a code cleanup that renamed the test module to match the source file remote.py. Approved by two reviewers, passed CI checks, and successfully integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged a chore to rename the remote-build test module to test_remote.py, aligning it with snapcraft/commands/remote.py. The change passed all linting and unit tests.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4382 (confidence 40%)

    Adjacent chore from the same author (906834cda, 'tests(remote-build): use less mocks') touching the same unit test file shortly before the rename.

Related issues

Issue Project State Summary Similarity
#6010 chore!: remove remote-build service override snapcraft merged Merged #6010 in commit 8bd9cc522, removing the legacy RemoteBuild service override and manual spread tests overlooked by #5994.
70%