← Back to issue list

tests: use less mocks in remote-build

View original Github issue

Metadata

Project
snapcraft
Number
#4382
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged changes replace mocked snapcraft.yaml loading in remote-build tests with direct file creation. Approved by two reviewers, passed CI, and serves as preparatory work for issue #4322.

Suggested action: —

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- Instead of mocking the function that loads a `snapcraft.yaml`, the tests now create and load the file. Preparatory work for #4322 (CRAFT-1977)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged changes replace mocked snapcraft.yaml loading in remote-build tests with direct file creation. Approved by two reviewers, passed CI, and serves as preparatory work for issue #4322.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Replaced mocked snapcraft.yaml loading functions in remote-build tests with direct file creation and loading. Serves as preparatory work for issue #4322.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Replaces mocked snapcraft.yaml loading in remote-build tests with direct file creation and loading. Prepares codebase for PR #4322 while maintaining test coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#299 fix(remote-build): minor edge cases found with snapcraft craft-application merged Fixed minor snapcraft edge cases in remote builds. Merged following approval by two reviewers and passing CI checks. The update modifies three files, adding 43 lines and removing 13.
76%
#196 feat: remote build service craft-application merged Merged the remote build service feature, migrating code from snapcraft. Approved by two reviewers, passed CI checks, and introduced 2316 lines across 26 files.
74%
#3648 cli: reintroduce remote-build and promote to snapcraft help snapcraft merged Merged the reintroduction of the remote-build CLI command and promoted it to snapcraft help. Approved by one reviewer, passed CI checks, and resolved Launchpad bug #1943244 via a single-file, four-line deletion.
72%
#4662 fix(test): do not create 2 snapcraft.yaml and confuse location snapcraft merged Merged a test fix preventing duplicate snapcraft.yaml creation in conflicting root and snap directories. Resolves silent overrides and ensures hooks are detected by clarifying fixture paths. Approved and merged.
72%
#4755 tests: fix devel base snap test snapcraft merged Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change.
72%
#2765 remote-build: initial Windows support snapcraft merged Merged initial Windows support for remote-build. Approved by one reviewer, adding 72 lines and removing 26 across six files. Requires snapcraft PR #2759.
72%
#3312 spread tests: introduce electron-builder test snapcraft merged Merged test case for electron-builder with useTemplate false. Compares generated snapcraft and meta YAML files to track upstream updates. Approved, passed CI, and added 385 lines across 11 files.
72%
#3076 remote-build: fix case where build log url is None snapcraft merged Merged a fix for a None build log URL in remote builds. Added logging and unit tests to resolve SNAPCRAFT-1JW and SNAPCRAFT-1FS. Approved by one reviewer, passed CI, and merged with 40 additions and 11 deletions across two files.
72%
#2096 tests: don't use os_release and repo from snapcraft snapcraft merged Merged PR removing os_release and repo imports from the snapcraft module in integration tests, replacing them with dedicated modules. Fixes #1982. Approved by two reviewers and merged despite a suggestion to extract shared functionality.
71%
#73 tests: add stage snaps integration test (CRAFT-68) craft-parts merged Merged an integration test verifying stage-snaps are correctly unpacked into the part install directory. Approved by two reviewers, passed CI, and added 133 lines across two files.
71%