tests: use less mocks in remote-build
Metadata
Current evaluation
PR #4382 merged (commit 906834cda): remote-build unit tests no longer mock snapcraft.yaml loading but write and load real project files, prep for #4322.
Resolution: closed resolved
Reason: The PR itself was merged into main as commit 906834cda ("tests(remote-build): use less mocks (#4382)"), passing review with no unresolved comments. It replaced the mocked snapcraft.yaml loader in the remote-build tests with real files, +38/-41 lines in one test file.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Instead of mocking the function that loads a `snapcraft.yaml`, the tests now create and load the file.
Preparatory work for #4322
(CRAFT-1977)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #4382 merged (commit 906834cda): remote-build unit tests no longer mock snapcraft.yaml loading but write and load real project files, prep for #4322. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #4382 (bc490f8), replacing mocked snapcraft.yaml loading in remote-build tests with real files as preparatory work for #4322. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes replace mocked snapcraft.yaml loading in remote-build tests with direct file creation. Approved by two reviewers, passed CI, and serves as preparatory work for issue #4322. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Replaced mocked snapcraft.yaml loading functions in remote-build tests with direct file creation and loading. Serves as preparatory work for issue #4322. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#4322
(confidence 80%)
Cited in the PR body as preparatory work for the remote-build build-id generation migration (CRAFT-1977)
-
Related To:
canonical/snapcraft#4385
(confidence 55%)
Follow-up commit 5fc76d839 'feat(remote-build): get build id' continues the same remote-build work
-
Related To:
canonical/snapcraft#4383
(confidence 50%)
Adjacent commit 4f7f4a58a 'chore: rename remote-build test' landed just before, touching the same test file
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2785 remote-build: add initial command unit tests | snapcraft | merged | PR #2785 by cjp256 merged into snapcraft master, adding initial unit tests for the remote-build command covering build-on arch handling; reviewer comments were addressed and the branch rebased. | |
| #3076 remote-build: fix case where build log url is None | snapcraft | merged | Merged in snapcraft#3076 (commit 2c1dfe63c), fixing remote-build handling when the build log URL is absent and adding unit coverage. | |
| #2716 tests: completely mock subversion tests | snapcraft | merged | Merged PR #2716 (commit 518083bb2) fully mocked the Subversion plugin unit tests in snapcraft, cutting their runtime while keeping integration tests for real behaviour. | |
| #299 fix(remote-build): minor edge cases found with snapcraft | craft-application | merged | Merged PR #299 fixed Snapcraft-related remote-build edge cases in three files, landing as commit 15087962 after two approvals. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR #2096 in commit 0e27e147d, replacing integration tests' use of Snapcraft's os_release and repo modules with test-specific helpers; it fixes #1982. | |
| #196 feat: remote build service | craft-application | merged | Merged PR #196 in commit e53de201, adding remote build service support and porting the latest remote-build implementation from Snapcraft. | |
| #4478 bug: remote-build broke in snapcraft 8.0 | snapcraft | closed | Fixed by PR #4482, merged as commit 6300e0ee2: remote-build pushes now use the Git CLI instead of libgit2, avoiding SSL broken-pipe failures. | |
| #3648 cli: reintroduce remote-build and promote to snapcraft help | snapcraft | merged | Merged PR #3648 (commit 8dc1ac016), restoring remote-build and promote in Snapcraft's main CLI help for Launchpad bug #1943244. |