← Back to issue list

fix(remote-build): warn instead of error when using unsupported bases

View original Github issue

Metadata

Project
snapcraft
Number
#4396
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4396 via commit 5d19d28bd to make remote-build warn instead of fail for unsupported bases, fixing #4357.

Resolution: closed resolved

Reason: PR #4396 was approved and merged, implementing the warning behavior for unsupported bases and explicitly fixing #4357.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- Fixes #4357

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4396 via commit 5d19d28bd to make remote-build warn instead of fail for unsupported bases, fixing #4357.
stealth/space-bunny-alpha — closed resolved Merged PR #4396 changed remote-build to warn instead of fail for unsupported bases, fixing the regression tracked in #4357 (commit 5d19d28bd).
qwen/qwen3.6-35b-a3b — — Merged into main after approval and CI. Changed remote builds to warn instead of error on unsupported bases, resolving #4357. Diff coverage is 88.88% with a minor overall decrease.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Remote builds now warn instead of erroring when unsupported bases are detected, resolving #4357. Approved by maintainer sergiusens despite a minor 0.01% test coverage decrease reported by Codecov.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4357 (confidence 100%)

    PR #4396 explicitly states that it fixes the remote-build regression tracked in #4357.

Related issues

Issue Project State Summary Similarity
#4343 feat(remote-build): check base before executing snapcraft merged Merged into main as commit 128e0acb2. Added base validation before remote-build, allowing fallback for core20/core22 while rejecting unsupported bases and fixing #4318.
79%
#3182 build providers: improve warning for unknown base snapcraft merged Merged in #3182 via commit 7346d937f, improving build-provider warnings for unknown bases.
74%
#4480 fix(remote): return error when remote build failed snapcraft merged Merged PR #4480 as commit 13aedd1d2, making remote builds return an error when a build fails and fixing #4142.
74%
#4432 fix(remote-build): improve logging and catch exceptions snapcraft merged Merged #4432, adding RemoteBuildError handling and improving remote-build logging for #4399; commits fb9a01d0b and 663dcdfab.
73%
#5265 fix(remotebuild): don't fail when cross-compiling snapcraft merged Merged PR #5265 fixed remote cross-compilation by sending build-on architectures to Launchpad; commit f94da8f13 closed #4996.
70%