fix(remote): return error when remote build failed
Metadata
Current evaluation
Merged PR #4480 as commit 13aedd1d2, making remote builds return an error when a build fails and fixing #4142.
Resolution: closed resolved
Reason: PR #4480 was approved and merged as commit 13aedd1d2. Its change makes Snapcraft propagate remote-build failures as errors, resolving issue #4142.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes: #4142
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4480 as commit 13aedd1d2, making remote builds return an error when a build fails and fixing #4142. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4480 (commit 13aedd1d2) makes remote-build return a non-zero error when remote builds fail, fixing issue #4142 where snapcraft exited 0 despite failed builds. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4480 (13aedd1d2) to return an error when remote builds fail, fixing #4142 after approval by three reviewers. | |
| qwen/qwen3.6-35b-a3b | — | — | Successfully merged fix for remote build failures that returns proper errors, resolving issue #4142. Approved by three reviewers with maintained code coverage across 13 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve issue #4142 by returning an error when remote builds fail. All modified lines are covered by tests, maintaining code coverage at 89.22%. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4142
(confidence 100%)
This was the defect explicitly fixed by PR #4480.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4432 fix(remote-build): improve logging and catch exceptions | snapcraft | merged | Merged #4432, adding RemoteBuildError handling and improving remote-build logging for #4399; commits fb9a01d0b and 663dcdfab. | |
| #4396 fix(remote-build): warn instead of error when using unsupported bases | snapcraft | merged | Merged #4396 via commit 5d19d28bd to make remote-build warn instead of fail for unsupported bases, fixing #4357. | |
| #4400 Return 1 if any remote-build failed | snapcraft | closed | Closed unmerged as superseded; the proposed flag was dropped in favor of commit 13aedd1d2, which makes remote-build return an error when a build fails. | |
| #5265 fix(remotebuild): don't fail when cross-compiling | snapcraft | merged | Merged PR #5265 fixed remote cross-compilation by sending build-on architectures to Launchpad; commit f94da8f13 closed #4996. | |
| #310 fix(remote-build): enable git repo check | craft-application | merged | Merged PR #310 in commit 28429b84, enabling remote builds to check Git cleanliness before staging and committing copied project changes. | |
| #1104 fix(remote-build): ignore dangling symlinks | craft-application | merged | Merged PR #1104 (commit 8256b7a2) makes remote-build copy the work tree with ignore_dangling_symlinks=True, fixing #1103. Merge conflicts resolved and changelog entry shipped under 7.1.1. | |
| #5052 fix: catch remote build errors | snapcraft | merged | Merged in #5052 (commit 741e36eb9), updating craft-application to 4.2.4 so remote-build errors are caught as CraftErrors and include documentation links; fixes #4908. |