fix(remote-build): parse `--launchpad-timeout` argument
Metadata
Current evaluation
Merged fix for a regression where the --launchpad-timeout argument was not parsed by the fallback remote builder. Resolves #4397 and was merged into the hotfix/7.5 branch.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Fix a regression where `--launchpad-timeout` was not parsed and could not be used by the fallback remote builder.
Note - I made 2 PRs (this one and #4426) because the remote build code is very different between `main` and the `hotfix/7.5` branches (`main` has the new remote builder code, `hotfix/7.5` does not).
Fixes #4397
(CRAFT-2094)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for a regression where the --launchpad-timeout argument was not parsed by the fallback remote builder. Resolves #4397 and was merged into the hotfix/7.5 branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into hotfix/7.5, resolving a regression that prevented the fallback remote builder from parsing the --launchpad-timeout CLI argument. The fix restores argument handling and closes issue #4397. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for a regression where the fallback remote builder failed to parse the --launchpad-timeout argument. Applied to hotfix/7.5 and resolves issue #4397. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4426 fix(remote-build): parse `--launchpad-timeout` argument | snapcraft | merged | Merged fix for parsing the --launchpad-timeout argument. Resolves a regression in the fallback remote builder and adds support for the new remote builder. Approved, passed CI, and merged to main. Fixes #4397. | |
| #2845 remote-build: configurable timeout/deadline for starting and monitoring build | snapcraft | merged | Merged configurable timeout and deadline handling for remote build start and monitoring. Review feedback was applied before approval, resolving ambiguous timeout errors and reinstating the --launchpad-timeout flag. |