← Back to issue list

fix(remote-build): parse `--launchpad-timeout` argument

View original Github issue

Metadata

Project
snapcraft
Number
#4427
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4427 as 0054b0cfe into hotfix/7.5, restoring parsing of --launchpad-timeout for the fallback remote builder. Companion PR #4426 (c6f41daa8) fixed the main branch code path. Fixes #4397.

Resolution: closed resolved

Reason: PR #4427 was approved and merged as commit 0054b0cfe on the hotfix/7.5 branch, adding the missing --launchpad-timeout argument parsing to the fallback remote builder, closing issue #4397. The parallel fix for the new main-branch remote builder landed separately as #4426 (c6f41daa8).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- Fix a regression where `--launchpad-timeout` was not parsed and could not be used by the fallback remote builder. Note - I made 2 PRs (this one and #4426) because the remote build code is very different between `main` and the `hotfix/7.5` branches (`main` has the new remote builder code, `hotfix/7.5` does not). Fixes #4397 (CRAFT-2094)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4427 as 0054b0cfe into hotfix/7.5, restoring parsing of --launchpad-timeout for the fallback remote builder. Companion PR #4426 (c6f41daa8) fixed the main branch code path. Fixes #4397.
stealth/space-bunny-alpha — closed resolved Merged #4427 as 0054b0cfe, restoring --launchpad-timeout parsing for the hotfix/7.5 fallback remote builder. Companion #4426 (c6f41daa8) fixed main; both address #4397.
qwen/qwen3.6-35b-a3b — — Merged fix for a regression where the --launchpad-timeout argument was not parsed by the fallback remote builder. Resolves #4397 and was merged into the hotfix/7.5 branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.5, resolving a regression that prevented the fallback remote builder from parsing the --launchpad-timeout CLI argument. The fix restores argument handling and closes issue #4397.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4397 (confidence 98%)

    Issue explicitly listed as fixed by this PR ('Fixes #4397', CRAFT-2094); the --launchpad-timeout option was not being parsed by remote-build.

  • Likely Fixed By: canonical/snapcraft#4426 (confidence 97%)

    Companion PR by the same author applying the same --launchpad-timeout parsing fix to the new main-branch remote builder (commit c6f41daa8); both PRs together resolve #4397.

  • Related To: canonical/snapcraft#2845 (confidence 72%)

    Original PR that introduced the configurable --launchpad-timeout deadline for remote builds (commit ba92ac5f7), whose option parsing was later lost in a regression.

Related issues

Issue Project State Summary Similarity
#4426 fix(remote-build): parse `--launchpad-timeout` argument snapcraft merged Merged #4426 as c6f41daa8, restoring --launchpad-timeout parsing for the new remote builder. Companion #4427 fixed the fallback builder, resolving #4397.
92%
#4397 `snapcraft remote-build --launchpad-timeout` does not work snapcraft closed Fixed Snapcraft 7 remote-build argument parsing in merged PRs #4426 (c6f41daa8) and #4427 (0054b0cfe), covering the main and fallback builders.
78%
#2845 remote-build: configurable timeout/deadline for starting and monitoring build snapcraft merged PR #2845 merged as ba92ac5f7, restoring --launchpad-timeout as a shared deadline for starting and monitoring remote builds and clarifying timeout failures.
75%
#224 fix(remotebuild): create the launchpad instance correctly craft-application merged Merged PR #224 as commit 87bc56a7, fixing remotebuild to create the Launchpad instance correctly.
70%