← Back to issue list

remote-build: configurable timeout/deadline for starting and monitoring build

View original Github issue

Metadata

Project
snapcraft
Number
#2845
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

PR #2845 merged as ba92ac5f7, restoring --launchpad-timeout as a shared deadline for starting and monitoring remote builds and clarifying timeout failures.

Resolution: closed resolved

Reason: The approved change was merged via PR #2845 in commit ba92ac5f7. It reinstates configurable timeout handling and improves failure reporting for Launchpad operations.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The error was ambiguous when the timeout was hit, and there was no recourse for the user. Re-instate a configurable timeout as `--launchpad-timeout` but apply it to both the start_build and monitor_build as a deadline. When Launchpad is slow, it may take some time to process the request, but as long as its Pending, we keep waiting for a response (unless deadline is hit).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2845 merged as ba92ac5f7, restoring --launchpad-timeout as a shared deadline for starting and monitoring remote builds and clarifying timeout failures.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#2845 via commit ba92ac5f7, restoring --launchpad-timeout as a shared deadline for build startup and monitoring with clearer timeout errors.
stealth/space-bunny-alpha — closed resolved Merged in #2845 via ba92ac5f7, restoring --launchpad-timeout as a shared deadline for starting and monitoring remote builds and clarifying timeout failures.
stealth/space-bunny-alpha — closed resolved Merged as ba92ac5f7, adding --launchpad-timeout as a shared deadline for starting and monitoring remote builds while waiting on Pending requests.
stealth/space-bunny-alpha — closed resolved Merged PR #2845, restoring --launchpad-timeout as a shared deadline for starting and monitoring remote builds and clarifying timeout failures.
qwen/qwen3.6-35b-a3b — — Merged configurable timeout and deadline handling for remote build start and monitoring. Review feedback was applied before approval, resolving ambiguous timeout errors and reinstating the --launchpad-timeout flag.
qwen3.6-35b-a3b-mtp-q6 — — Merged cjp256's PR adding a configurable --launchpad-timeout deadline for remote builds. Applies to starting and monitoring, resolving ambiguous errors and handling slow Launchpad responses by waiting while pending.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4426 fix(remote-build): parse `--launchpad-timeout` argument snapcraft merged Merged #4426 as c6f41daa8, restoring --launchpad-timeout parsing for the new remote builder. Companion #4427 fixed the fallback builder, resolving #4397.
79%
#4427 fix(remote-build): parse `--launchpad-timeout` argument snapcraft merged Merged #4427 as 0054b0cfe into hotfix/7.5, restoring parsing of --launchpad-timeout for the fallback remote builder. Companion PR #4426 (c6f41daa8) fixed the main branch code path. Fixes #4397.
75%
#618 Remote build does cleanup even after a timeout craft-application closed Remote-build cleaned up build resources after a --launchpad-timeout; fixed by PR #625 (commit 7c636d3a) which raises TimeoutError so the handler returns exit 75 without cleanup. Shipped in 4.8.3.
74%
#4397 `snapcraft remote-build --launchpad-timeout` does not work snapcraft closed Fixed Snapcraft 7 remote-build argument parsing in merged PRs #4426 (c6f41daa8) and #4427 (0054b0cfe), covering the main and fallback builders.
72%
#2709 On timeout, `remote-build` should return the artifacts that have successfully finished building charmcraft open Feature request: `remote-build` returns 75 on --launchpad-timeout without fetching already-successful artifacts; maintainer-linked to the pending --build-for request #2467. Still open and unlabelled.
71%