fix(remote-build): parse `--launchpad-timeout` argument
Metadata
Current evaluation
Merged #4426 as c6f41daa8, restoring --launchpad-timeout parsing for the new remote builder. Companion #4427 fixed the fallback builder, resolving #4397.
Resolution: closed resolved
Reason: PR #4426 merged into main as c6f41daa8 and added --launchpad-timeout support to the new remote builder. Companion PR #4427 merged as 0054b0cfe to restore parsing in the 7.5 fallback builder, fully resolving #4397.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Two changes:
1. Fix a regression where `--launchpad-timeout` was not parsed and could not be used by the fallback remote builder.
2. Add support for `--launchpad-timeout` in new remote builder
Note - I made 2 PRs (this one and #4427) because the remote build code is very different between `main` and the `hotfix/7.5` branches (`main` has the new remote builder code, `hotfix/7.5` does not).
Fixes #4397
(CRAFT-2094)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4426 as c6f41daa8, restoring --launchpad-timeout parsing for the new remote builder. Companion #4427 fixed the fallback builder, resolving #4397. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4426 merged as c6f41daa, adding --launchpad-timeout parsing/support to the new remote builder; companion PR #4427 (0054b0cfe) fixed the 7.5 fallback builder, together resolving #4397. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4426 (c6f41daa), adding --launchpad-timeout support to the new remote builder. The fallback-builder fix was merged separately in #4427, resolving #4397. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for parsing the --launchpad-timeout argument. Resolves a regression in the fallback remote builder and adds support for the new remote builder. Approved, passed CI, and merged to main. Fixes #4397. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for a regression preventing the fallback remote builder from parsing the --launchpad-timeout argument. Added support for the flag in the new remote builder. Resolves #4397 and increased unit test coverage by 0.02%. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#4427
(confidence 100%)
Companion PR merged as 0054b0cfe to fix --launchpad-timeout parsing in the hotfix/7.5 fallback builder.
-
Related To:
canonical/snapcraft#4397
(confidence 100%)
The reported --launchpad-timeout regression was closed by the fixes in #4426 and #4427.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4427 fix(remote-build): parse `--launchpad-timeout` argument | snapcraft | merged | Merged #4427 as 0054b0cfe into hotfix/7.5, restoring parsing of --launchpad-timeout for the fallback remote builder. Companion PR #4426 (c6f41daa8) fixed the main branch code path. Fixes #4397. | |
| #4397 `snapcraft remote-build --launchpad-timeout` does not work | snapcraft | closed | Fixed Snapcraft 7 remote-build argument parsing in merged PRs #4426 (c6f41daa8) and #4427 (0054b0cfe), covering the main and fallback builders. | |
| #2845 remote-build: configurable timeout/deadline for starting and monitoring build | snapcraft | merged | PR #2845 merged as ba92ac5f7, restoring --launchpad-timeout as a shared deadline for starting and monitoring remote builds and clarifying timeout failures. | |
| #618 Remote build does cleanup even after a timeout | craft-application | closed | Remote-build cleaned up build resources after a --launchpad-timeout; fixed by PR #625 (commit 7c636d3a) which raises TimeoutError so the handler returns exit 75 without cleanup. Shipped in 4.8.3. | |
| #224 fix(remotebuild): create the launchpad instance correctly | craft-application | merged | Merged PR #224 as commit 87bc56a7, fixing remotebuild to create the Launchpad instance correctly. |