fix(remote-build): parse `--launchpad-timeout` argument
Metadata
Current evaluation
Merged fix for parsing the --launchpad-timeout argument. Resolves a regression in the fallback remote builder and adds support for the new remote builder. Approved, passed CI, and merged to main. Fixes #4397.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Two changes:
1. Fix a regression where `--launchpad-timeout` was not parsed and could not be used by the fallback remote builder.
2. Add support for `--launchpad-timeout` in new remote builder
Note - I made 2 PRs (this one and #4427) because the remote build code is very different between `main` and the `hotfix/7.5` branches (`main` has the new remote builder code, `hotfix/7.5` does not).
Fixes #4397
(CRAFT-2094)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for parsing the --launchpad-timeout argument. Resolves a regression in the fallback remote builder and adds support for the new remote builder. Approved, passed CI, and merged to main. Fixes #4397. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for a regression preventing the fallback remote builder from parsing the --launchpad-timeout argument. Added support for the flag in the new remote builder. Resolves #4397 and increased unit test coverage by 0.02%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for regression parsing --launchpad-timeout in the fallback remote builder, adding support for the flag in the new builder. Resolves #4397. Coverage increased by 0.02% with 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4427 fix(remote-build): parse `--launchpad-timeout` argument | snapcraft | merged | Merged fix for a regression where the --launchpad-timeout argument was not parsed by the fallback remote builder. Resolves #4397 and was merged into the hotfix/7.5 branch. | |
| #2845 remote-build: configurable timeout/deadline for starting and monitoring build | snapcraft | merged | Merged configurable timeout and deadline handling for remote build start and monitoring. Review feedback was applied before approval, resolving ambiguous timeout errors and reinstating the --launchpad-timeout flag. | |
| #224 fix(remotebuild): create the launchpad instance correctly | craft-application | merged | Approved by two reviewers and passing CI, the fix to correctly create the remotebuild launchpad instance was successfully merged. | |
| #625 fix(remote-build): don't cleanup after a timeout | craft-application | merged | Merged fix preventing remote builder cleanup after timeouts and removing references to a non-existent --build-id option. Approved by two reviewers, passed CI, and rebased to main for release 4.8.3. Resolves #618 and #619. | |
| #4892 fix(remotebuild): use legacy launchpad credentials if they exist | snapcraft | merged | Merged fix enabling legacy Launchpad credential fallback for remote builds with a deprecation warning. Added build-for all support, updated spread tests, and resolved issue 4889. Requires craft-application 3.1.0+. Approved and passed CI. | |
| #4432 fix(remote-build): improve logging and catch exceptions | snapcraft | merged | Merged pull request improving remote build logging and exception handling. Approved by reviewers, passed CI checks, and resolves issue #4399. |