test(lifecycle): add test for check patchelf when override
Metadata
Current evaluation
PR #4524 was closed unmerged as outdated; snapcraft#4553 superseded it by adding a warning for override-prime combined with patchelf.
Resolution: closed superseded
Reason: The test-only PR was closed without merge and left with two unresolved review comments. canonical/snapcraft#4553 landed as commit 4a3a0622b and directly addressed the override-prime/patchelf behavior.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`patchelf` will not be executed when
```
override-prime: |
craftctl default
```
The reason is snapcraft patchelf using the craft-parts states to get files list and run patchelf. However when override, the list is empty due the the parts code skipped. So the patchelf will not run on any files.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #4524 was closed unmerged as outdated; snapcraft#4553 superseded it by adding a warning for override-prime combined with patchelf. | |
| stealth/space-bunny-alpha | — | closed superseded | PR #4524 was closed unmerged as outdated, without adding its patchelf/override-prime coverage. PR #4553 superseded it, adding a warning for unsafe override-prime use in commit 4a3a0622b. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as outdated; its override-prime patchelf test was not incorporated. PR #4553 later added a warning for this unsafe configuration. | |
| stealth/space-bunny-alpha | — | closed stale | PR #4524 was closed without merge and left outdated, with two unresolved review comments; the patchelf override-prime test was not incorporated. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merge. The PR added tests for a patchelf behavior during override-prime but remained outdated with unresolved comments, indicating it was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned. The pull request added a test to verify patchelf execution during override-prime but was not merged. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#4553
(confidence 98%)
Commit 4a3a0622b added the corresponding override-prime and patchelf warning.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4547 Warn when using `override-prime` and `enable-patchelf` | snapcraft | closed | Warning added for enable-patchelf combined with override-prime, which can leave binaries unpatched. Fixed by merged PR #4553 (commit 4a3a0622b), shipped in Snapcraft 8.0.3. | |
| #5135 fix(test): add patchelf to dev dependencies for testing | snapcraft | closed | Closed unmerged as obsolete after #5225 superseded the proposed patchelf test dependency; the Starflow migration merged in commit 7a1a94e46. |