← Back to issue list

test(lifecycle): add test for check patchelf when override

View original Github issue

Metadata

Project
snapcraft
Number
#4524
Type
pull request
State
closed
Author
syu-w
Labels
Created
Updated
Closed

Current evaluation

Closed without merge. The PR added tests for a patchelf behavior during override-prime but remained outdated with unresolved comments, indicating it was abandoned.

Suggested action:

No scores available.

Issue body

`patchelf` will not be executed when ``` override-prime: | craftctl default ``` The reason is snapcraft patchelf using the craft-parts states to get files list and run patchelf. However when override, the list is empty due the the parts code skipped. So the patchelf will not run on any files.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without merge. The PR added tests for a patchelf behavior during override-prime but remained outdated with unresolved comments, indicating it was abandoned.
qwen3.6-35b-a3b-mtp-q6 Abandoned. The pull request added a test to verify patchelf execution during override-prime but was not merged.
qwen3.6-35b-a3b-mtp-q6 Added a test for patchelf execution during override-prime to address an empty file list issue. The pull request was closed without being merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5135 fix(test): add patchelf to dev dependencies for testing snapcraft closed Superseded by PR #5225. The pull request adding patchelf to dev dependencies was closed as obsolete after maintainers discussed architectural concerns regarding patchelf usage in tests and development environments.
78%
#1983 snap: update revision of patchelf to use snapcraft closed Closed without merging. The patchelf revision update received no reviews, comments, or CI checks, indicating it was abandoned or superseded by a later change.
71%