fix(remote): parse comma-separated architectures
Metadata
Current evaluation
Merged in snapcore/snapcraft#4543 as b8eed87c0, fixing comma-separated remote-build architectures and enforcing --build-for/--build-on exclusivity.
Resolution: closed resolved
Reason: PR #4543 was approved and merged as commit b8eed87c0. It fixed snapcore/snapcraft#4516 by parsing comma-separated architectures and making --build-for and --build-on mutually exclusive.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
2 commits:
- fix(remote): make `--build-for` and `--build-on` mutually exclusive
- This was not working as intended (and was not tested)
- This is only for the new remote-build and makes no changes to how legacy remote build handles these arguments
- fix(remote): parse comma-separated architectures
- This uses the same style that legacy remote-build uses for passing architectures - a single comma-separated set
Fixes #4516
(CRAFT-2386)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#4543 as b8eed87c0, fixing comma-separated remote-build architectures and enforcing --build-for/--build-on exclusivity. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as b8eed87c0: fixed remote-build parsing of comma-separated architectures and made --build-for/--build-on mutually exclusive, resolving #4516. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4543 (b8eed87c0) fixed comma-separated architecture parsing for remote builds and made --build-for/--build-on mutually exclusive, resolving #4516. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as b8eed87c0: remote builds now parse comma-separated architectures and enforce --build-for/--build-on exclusivity, fixing #4516. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval. Resolves #4516 by enforcing mutual exclusivity between --build-for and --build-on, and adding comma-separated architecture parsing for remote builds. Proceeded despite unrelated spread test failures. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for remote build argument parsing. Implements comma-separated architecture parsing and enforces mutual exclusivity between --build-for and --build-on. Maintainer merged despite unrelated spread test failures, resolving issue #4516. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#4516
(confidence 100%)
Remote-build architecture regression explicitly fixed by merged PR #4543.
-
Related To:
snapcore/snapcraft#5028
(confidence 90%)
Later restored comma-separated remote-build parsing after the behavior regressed again.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5028 fix(remotebuild): parse comma-separated architectures | snapcraft | merged | Merged PR #5028 (commit 189edf429) restored comma-separated parsing for remote-build --build-for and --platform, fixing #4990. | |
| #2007789 `snapcraft remote-build` does not support long syntax of the `architectures` top-level key. | snapcraft (launchpad) | closed | Fixed by migrating `snapcraft remote-build` to the core22 implementation, which correctly parses the long `architectures` syntax. | |
| #4780 remote build: fails with some architecture definitions | snapcraft | closed | Remote-build architecture handling was fixed by merged PR canonical/snapcraft#4793 (commit 53ec55cef), with companion support in canonical/craft-application#343. | |
| #4516 regression: remote-build doesn't accept comma-seperated architectures | snapcraft | closed | Comma-separated remote-build architectures were fixed by merged PR #4543 (b8eed87c0); a later regression was superseded by #4990 and fixed by merged PR #5028 (189edf429). | |
| #1885150 Cannot use --build-on, architecture list is already set in snapcraft.yaml. | snapcraft (launchpad) | closed | Resolved in Snapcraft 8.7.0: remote-build added --build-for filtering for projects defining architectures or platforms, replacing the unusable --build-on workaround. | |
| #3821 meta: architectures | snapcraft | merged | Merged core22 architecture support, including build-on/build-for handling, host and build-instance selection, and SNAPCRAFT_BUILD_FOR filtering, via commit 4876b53. | |
| #4150 meta: use build-for in snap.yaml architecture | snapcraft | merged | Merged #4150 as 77d3454d: build-for: all now writes architectures: all to meta/snap.yaml instead of the build-on architecture, fixing CRAFT-1535. | |
| #299 fix(remote-build): minor edge cases found with snapcraft | craft-application | merged | Merged PR #299 fixed Snapcraft-related remote-build edge cases in three files, landing as commit 15087962 after two approvals. | |
| #5606 schema: add build-for in architectures for core22 | snapcraft | merged | Merged as c9822a38c via snapcraft#5606, adding build-for to the core22 architectures schema in snapcraft.json. | |
| #1999580 core22: wrong arch in snap.yaml when building for all archs | snapcraft (launchpad) | closed | Fixed in merged canonical/snapcraft#4150 (commit 77d3454d): core22 snap.yaml now records build-for (all) instead of the build-on architecture. |