← Back to issue list

fix(remotebuild): parse comma-separated architectures

View original Github issue

Metadata

Project
snapcraft
Number
#5028
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5028 (commit 189edf429) restored comma-separated parsing for remote-build --build-for and --platform, fixing #4990.

Resolution: closed resolved

Reason: PR #5028 was approved and merged as commit 189edf429, enabling comma-separated values for both remote-build architecture options.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Allow comma-separated values for `--build-for` and `--platform`. Remote build spread tests are successful: https://github.com/canonical/snapcraft/actions/runs/10814283451/job/30000756052 Fixes #4990 (CRAFT-3271)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5028 (commit 189edf429) restored comma-separated parsing for remote-build --build-for and --platform, fixing #4990.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#5028 (commit 189edf429), restoring comma-separated parsing for --build-for and --platform in remote builds and fixing #4990.
qwen/qwen3.6-35b-a3b — — Merged fix for issue #4990 enabling comma-separated architecture parsing for --build-for and --platform remote build arguments. Approved by two reviewers and verified via passing CI and spread tests.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix enabling comma-separated architecture parsing for --build-for and --platform in remote builds. Resolves issue #4990 and passes all spread tests.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4990 (confidence 100%)

    PR #5028 explicitly fixes the remote-build comma-separated architecture issue reported in #4990.

Related issues

Issue Project State Summary Similarity
#4990 remote build: Allow comma-separated values for `--build-for` and `--platform` snapcraft closed Regression in remote-build parsing of comma-separated `--build-for`/`--platform` values was restored by merged PR #5028 (commit 189edf429). Maintainer mr-cal closed the issue on 2024-09-13 pointing to #5028.
82%
#4516 regression: remote-build doesn't accept comma-seperated architectures snapcraft closed Comma-separated remote-build architectures were fixed by merged PR #4543 (b8eed87c0); a later regression was superseded by #4990 and fixed by merged PR #5028 (189edf429).
81%
#4994 fix(remotebuild): parse '--build-for' and '--platform' snapcraft merged Merged as 5cd480725: remote-build now parses and validates --build-for and --platform, enforces usage restrictions, and updates error and command documentation.
78%
#4543 fix(remote): parse comma-separated architectures snapcraft merged Merged in snapcore/snapcraft#4543 as b8eed87c0, fixing comma-separated remote-build architectures and enforcing --build-for/--build-on exclusivity.
77%