← Back to issue list

fix(remote-build): minor edge cases found with snapcraft

View original Github issue

Metadata

Project
craft-application
Number
#299
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #299 fixed Snapcraft-related remote-build edge cases in three files, landing as commit 15087962 after two approvals.

Resolution: closed resolved

Reason: PR #299 was merged after two approvals, resolving the remote-build edge cases in commit 15087962.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #299 fixed Snapcraft-related remote-build edge cases in three files, landing as commit 15087962 after two approvals.
stealth/space-bunny-alpha — closed resolved Merged as commit 15087962, fixing minor Snapcraft-related edge cases in remote builds.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-application#299 as commit 15087962, fixing minor Snapcraft-related edge cases in remote builds across three files (+43/−13).
qwen/qwen3.6-35b-a3b — — Fixed minor snapcraft edge cases in remote builds. Merged following approval by two reviewers and passing CI checks. The update modifies three files, adding 43 lines and removing 13.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3076 remote-build: fix case where build log url is None snapcraft merged Merged in snapcraft#3076 (commit 2c1dfe63c), fixing remote-build handling when the build log URL is absent and adding unit coverage.
77%
#196 feat: remote build service craft-application merged Merged PR #196 in commit e53de201, adding remote build service support and porting the latest remote-build implementation from Snapcraft.
74%
#4478 bug: remote-build broke in snapcraft 8.0 snapcraft closed Fixed by PR #4482, merged as commit 6300e0ee2: remote-build pushes now use the Git CLI instead of libgit2, avoiding SSL broken-pipe failures.
74%
#2785 remote-build: add initial command unit tests snapcraft merged PR #2785 by cjp256 merged into snapcraft master, adding initial unit tests for the remote-build command covering build-on arch handling; reviewer comments were addressed and the branch rebased.
73%
#4382 tests: use less mocks in remote-build snapcraft merged PR #4382 merged (commit 906834cda): remote-build unit tests no longer mock snapcraft.yaml loading but write and load real project files, prep for #4322.
73%
#3648 cli: reintroduce remote-build and promote to snapcraft help snapcraft merged Merged PR #3648 (commit 8dc1ac016), restoring remote-build and promote in Snapcraft's main CLI help for Launchpad bug #1943244.
73%
#2734 SnapcraftError refactoring snapcraft merged SnapcraftError refactoring was merged in canonical/snapcraft#2734 after maintainer approval, updating four files (+279/-26).
72%
#4543 fix(remote): parse comma-separated architectures snapcraft merged Merged in snapcore/snapcraft#4543 as b8eed87c0, fixing comma-separated remote-build architectures and enforcing --build-for/--build-on exclusivity.
72%
#590 Integrate with new remote parts snapcraft merged Merged PR #590 as commit 9c9fb6949, integrating Snapcraft with the new remote-parts service and updating part loading, caching, and related tests.
72%
#5676 remote build: remove legacy remote builder snapcraft closed Fixed in merged PR #5994 (commit b08f1a66e) for Snapcraft 9.0 by removing the legacy remote builder, selection logic, strategy env var, and legacy credential support.
71%