← Back to issue list

fix(remote-build): minor edge cases found with snapcraft

View original Github issue

Metadata

Project
craft-application
Number
#299
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Fixed minor snapcraft edge cases in remote builds. Merged following approval by two reviewers and passing CI checks. The update modifies three files, adding 43 lines and removing 13.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Fixed minor snapcraft edge cases in remote builds. Merged following approval by two reviewers and passing CI checks. The update modifies three files, adding 43 lines and removing 13.
qwen3.6-35b-a3b-mtp-q6 Merged fixes for minor snapcraft remote-build edge cases. Maintainer lengau's changes were integrated into the main branch without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#196 feat: remote build service craft-application merged Merged the remote build service feature, migrating code from snapcraft. Approved by two reviewers, passed CI checks, and introduced 2316 lines across 26 files.
78%
#4382 tests: use less mocks in remote-build snapcraft merged Merged changes replace mocked snapcraft.yaml loading in remote-build tests with direct file creation. Approved by two reviewers, passed CI, and serves as preparatory work for issue #4322.
76%
#2765 remote-build: initial Windows support snapcraft merged Merged initial Windows support for remote-build. Approved by one reviewer, adding 72 lines and removing 26 across six files. Requires snapcraft PR #2759.
74%
#3076 remote-build: fix case where build log url is None snapcraft merged Merged a fix for a None build log URL in remote builds. Added logging and unit tests to resolve SNAPCRAFT-1JW and SNAPCRAFT-1FS. Approved by one reviewer, passed CI, and merged with 40 additions and 11 deletions across two files.
74%
#3648 cli: reintroduce remote-build and promote to snapcraft help snapcraft merged Merged the reintroduction of the remote-build CLI command and promoted it to snapcraft help. Approved by one reviewer, passed CI checks, and resolved Launchpad bug #1943244 via a single-file, four-line deletion.
73%
#86 meta: use snapcraft's versioning scheme starbase merged Merged after two approvals and passing CI. Updates the versioning scheme to match snapcraft's using setuptools-scm, adding 78 lines across two files with zero coverage impact.
73%
#1596114 adt, cannot snapcraft clean without remote parts when in use snapcraft (launchpad) closed Fixed test failures where snapcraft clean failed due to missing remote parts cache. Updated the test suite to run snapcraft update before cleaning. Verified and closed.
73%
#2642 remote-build: detect early build errors snapcraft merged Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied.
73%
#636 feat: add a "pending" status to remote builds craft-application merged Merged the feature adding a pending status to remote builds. The change upstreams code from canonical/snapcraft#4956, received two approvals, and modified four files with 43 additions and 15 deletions.
73%
#5265 fix(remotebuild): don't fail when cross-compiling snapcraft merged Merged fix resolving remote build cross-compilation failures. Snapcraft now passes build-on architectures to Launchpad instead of build-for, enabling correct cross-compilation and addressing issue #4996. Approved by reviewers and passed CI.
72%