feat!: fail if we know the project is core24
Metadata
Current evaluation
PR #4556 was closed unmerged and stale after no review or CI; core24 support later arrived via PR #4693 (commit ab1c86df3), using Craft Application/core22 components.
Resolution: closed stale
Reason: PR #4556 received no maintainer review or passing CI and was closed without being merged, leaving its rejection behavior unadopted. Core24 builds were subsequently delivered by merged PR #4693 at commit ab1c86df3.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #4556 was closed unmerged and stale after no review or CI; core24 support later arrived via PR #4693 (commit ab1c86df3), using Craft Application/core22 components. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged after 974 days without review; the proposed core24 rejection was not adopted. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged after remaining unreviewed for 974 days; the proposed explicit failure for known core24 projects was not adopted. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after 974 days without review; core24 support was later introduced through separate work, including snapcraft/snapcraft#4693. | |
| stealth/space-bunny-alpha | — | closed stale | PR #4556 was closed unmerged after remaining unreviewed; its 929-line proposal to reject known core24 projects was not adopted. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. Remained pending review with zero reviewers and only received a Codecov coverage warning. No CI results or merge activity were recorded, indicating the pull request was likely abandoned or rejected. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Changes to fail on core24 projects were closed without merging. A Codecov report flagged missing test coverage, and no follow-up occurred, indicating the pull request was abandoned due to failing coverage requirements. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#4693
(confidence 92%)
Added core24 builds through Craft Application and core22 components, providing support instead of the proposed failure behavior.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4692 feat: core24 using Craft Application and core22 components | snapcraft | closed | Closed unmerged and superseded by canonical/snapcraft#4693 (merge commit ab1c86df3), which landed the same core24 Craft Application / core22 components work; branch was protected. | |
| #4557 feat!: fail if we know the project is core24 | snapcraft | merged | Merged in #4557 as commit 2be27d147, adding early failure for known core24 projects, expected-failure core24 spread tests, and feature-branch CI updates. | |
| #4693 feat: core24 using Craft Application and core22 components | snapcraft | merged | Merged as commit ab1c86df3: snaps with base core24 are now built using Craft Application and core22 components, a large change (284 files, +10487/-1939) in snapcraft. | |
| #4565 feat: implement core24 "pack" command | snapcraft | merged | Rebase-merged PR #4565 (commit e75d0e93b) on feature/craft-application: implemented the core24 "pack" command (Package service) plus "clean", re-enabled their spread tests and updated expected errors. Closes #4470. |