← Back to issue list

feat: implement core24 "pack" command

View original Github issue

Metadata

Project
snapcraft
Number
#4565
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Rebase-merged PR #4565 (commit e75d0e93b) on feature/craft-application: implemented the core24 "pack" command (Package service) plus "clean", re-enabled their spread tests and updated expected errors. Closes #4470.

Resolution: closed resolved

Reason: The PR itself was merged via rebase-merge into the feature/craft-application branch in commit e75d0e93b, implementing the Package (pack) service and the clean command; it carries "Fixes #4470" and issue #4470 was closed by it. Known spread-test failures from other missing craft-application features (e.g. adopt-info) were explicitly accepted by maintainers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

As before, this PR is split over multiple commits: - First one is mostly a cherry-pick of @lengau and @mr-cal 's prototype. I had to do some minor changes to satisfy linters but nothing major; - Second commit adds the "clean" command, just because it's so easy to implement and used by basically every spread test; - Third commit re-enables "pack" and "clean" in a bunch of spread tests; - Final commit updates the expected error messages for those tests that are still failing due to _other_ missing features. One unfortunate consequence of the spread parametrization that we do in some tests is that now there's no easy way to handle some tests; for instance, `tests/spread/core24/craftctl` has three "subtests" as spread parameters; one is passing and two are failing (because they need adopt-info). Rather than doing a complicated logic in bash to handle this, I think we might just accept these failures in this feature-branch while we work on the issues. If that's acceptable, it means we'll need someone with admin access to ultimately merge this when it's approved.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Rebase-merged PR #4565 (commit e75d0e93b) on feature/craft-application: implemented the core24 "pack" command (Package service) plus "clean", re-enabled their spread tests and updated expected errors. Closes #4470.
stealth/space-bunny-alpha — closed resolved PR #4565 by tigarmo rebase-merged into the feature/craft-application branch as commit e75d0e93b, implementing the core24 "pack" command plus a new "clean" command and re-enabling their spread tests. It resolves #4470.
stealth/space-bunny-alpha — closed resolved Rebase-merged PR #4565 in commit e75d0e93b, implementing core24 pack and clean commands and re-enabling their spread tests. It resolves #4470; expected failures from other missing craft-application features were accepted.
stealth/space-bunny-alpha — closed resolved Merged PR #4565, adding core24 pack and clean commands, updating spread tests, and fixing #4470.
qwen/qwen3.6-35b-a3b — — Merged the core24 pack and clean command implementation. Maintainer rebase-merged after two approvals, resolving #4470. Known test failures from missing dependencies were intentionally accepted to advance the craft-application branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged core24 pack and clean command implementation. Rebase-merged into the feature branch, fixing #4470. Expected test failures for missing features were accepted. Changes were approved and integrated.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4470 (confidence 99%)

    Issue 'feature/craft-application: implement Package service', closed as fixed by this PR.

Related issues

Issue Project State Summary Similarity
#4717 feat: package component hooks for core24 snapcraft merged Merged PR #4717 as commit aafbe672b, adding core24 component-hook packaging and test coverage for CRAFT-2540.
77%
#4470 feature/craft-application: implement Package service snapcraft closed Package service was completed by merged PR snapcraft#4565 (commit e75d0e93b), adding the core24 pack command and related lifecycle tests.
75%
#4692 feat: core24 using Craft Application and core22 components snapcraft closed Closed unmerged and superseded by canonical/snapcraft#4693 (merge commit ab1c86df3), which landed the same core24 Craft Application / core22 components work; branch was protected.
74%
#1399 feat: craft-application rebase charmcraft merged Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs.
73%
#4617 feat(craft-application): support root packages for core24 snapcraft merged Merged PR #4617 added core24 support for root-level build-packages and build-snaps, fixing #4605; landed as 397f4c8c3.
72%
#30 feat: merge 'bundle-snap' into 'core24-8' snapcraft-rocks merged PR #30 merged into core24-8, bringing in #28's bundled base-snap changes and updating the bundled code to Core24; two reviewers approved it.
72%
#1275 feat: use craft-application for pack command charmcraft closed Closed unmerged as superseded after a get_build_plan error. The broader craft-application migration landed in #1538 (5e3b927c), followed by pack-command cleanup in #1704 (cfc37020).
72%
#4693 feat: core24 using Craft Application and core22 components snapcraft merged Merged as commit ab1c86df3: snaps with base core24 are now built using Craft Application and core22 components, a large change (284 files, +10487/-1939) in snapcraft.
72%
#4556 feat!: fail if we know the project is core24 snapcraft closed PR #4556 was closed unmerged and stale after no review or CI; core24 support later arrived via PR #4693 (commit ab1c86df3), using Craft Application/core22 components.
71%