← Back to issue list

feat: allow for overriding project asset handling

View original Github issue

Metadata

Project
snapcraft
Number
#4628
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. Enables overriding project asset handling by consolidating executable settings and adding tests for hook interactions. Approved by two reviewers, passed CI checks, and maintained test coverage.

Suggested action:

No scores available.

Issue body

- Move executable setting to one location - Test for default behavior in relation to hooks - Test with new asset handler in relation to hooks - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Enables overriding project asset handling by consolidating executable settings and adding tests for hook interactions. Approved by two reviewers, passed CI checks, and maintained test coverage.
qwen3.6-35b-a3b-mtp-q6 Merged feature allowing override of project asset handling. Centralized executable configuration and added tests for hook interactions with the new asset handler. Successfully passed CI and code coverage checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Enables overriding project asset handling by consolidating executable configuration and adding tests for default behavior and hook integration. Passed CI and achieved full coverage on modified lines.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3364 project loader: ensure all key assets are utilized snapcraft merged Merged into master. Updates the project loader to raise an error when key assets are unutilized. Approved by a reviewer, passed CI checks, and integrated despite a minor coverage decrease.
74%
#238 feat!: remove optional project commands craft-application merged Merged changes removing optional project commands to enforce explicit project requirements. Approved by two reviewers and passing CI. Reverts #213 while retaining relevant tests.
73%
#1472 feat: add override-overlay craft-parts merged Merged the override-overlay feature. Approved by two reviewers with 180 additions and 35 deletions across 10 files. Passed required CI checks and was successfully integrated into the codebase.
73%
#149 feat: resolvable project path craft-application merged Implemented resolvable project path feature to resolve issue #148. Merged after approval from two reviewers, passing CI checks and achieving 99.23% test coverage. Changes modified two files with 140 additions and 37 deletions.
71%
#1357 feat: skip repacking if project is unchanged rockcraft closed Merged. Skips repacking output artifacts when the project is unchanged by leveraging the craft-application mediation API. Approved by two reviewers with all CI checks passing.
71%
#213 feat: add optimistic project loading craft-application merged Merged. Optimistic project loading allows commands with always_load_project set to try to attempt loading without failing if unavailable. Approved by three reviewers, passed CI, and modified three files (+102/-19).
70%