← Back to issue list

feat: skip repacking if project is unchanged

View original Github issue

Metadata

Project
rockcraft
Number
#1357
Type
pull request
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #1357 by cmatsuoka merged as commit 0b6ba8bd, adopting the craft-application mediation API so Rockcraft skips repacking output artifacts when the project is unchanged. All checks passed.

Resolution: closed resolved

Reason: The pull request was approved by 2 reviewers with no unresolved comments and landed on main as commit 0b6ba8bd ("feat: skip repacking if project is unchanged (#1357)"), with the full CI suite passing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Use the craft-application mediation API to avoid repacking the output artifact if no changes are made to the project. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1357 by cmatsuoka merged as commit 0b6ba8bd, adopting the craft-application mediation API so Rockcraft skips repacking output artifacts when the project is unchanged. All checks passed.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#1357, using craft-application's mediation API to skip repacking output artifacts when the project is unchanged.
stealth/space-bunny-alpha — closed resolved Merged canonical/rockcraft#1357, adding craft-application mediation to skip output-artifact repacking when the project is unchanged.
qwen/qwen3.6-35b-a3b — — Merged. Skips repacking output artifacts when the project is unchanged by leveraging the craft-application mediation API. Approved by two reviewers with all CI checks passing.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 29
Staleness: 5
Complexity: 35
Confidence: 85
needs review PR implements conditional repacking using craft-application's mediation API to skip repacking when project artifacts are unchanged. Has 2 approvals, passing CI, and no unresolved review comments.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 30
Staleness: 10
Complexity: 45
Confidence: 75
needs review PR implements conditional repacking using craft-application API to skip repacking when project is unchanged. Has 2 approvals, 2 unresolved review comments, all CI passing, and recent activity.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 30
Staleness: 25
Complexity: 45
Confidence: 70
needs review Optimization to skip repacking when project is unchanged using craft-application mediation API. Approved by 1 reviewer with 1 unresolved comment and one failing CI check (source-spread-tests).
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 30
Staleness: 15
Complexity: 45
Confidence: 75
needs review Adds conditional repacking using craft-application API to skip repacking when project is unchanged. Has 1 approval, 1 unresolved review comment, and passing CI.
qwen/qwen3.6-35b-a3b
Impact: 35
Quick Win: 19
Staleness: 15
Complexity: 45
Confidence: 75
needs review Feature to skip repacking when project is unchanged using craft-application mediation API. Has 1 approval, 1 unresolved review comment, and a failing lint CI check.
qwen/qwen3.6-35b-a3b
Impact: 35
Quick Win: 19
Staleness: 35
Complexity: 45
Confidence: 65
needs review PR uses craft-application mediation API to skip repacking when project is unchanged. Approved by 1 reviewer with 1 unresolved comment, all CI passing.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 30
Staleness: 10
Complexity: 45
Confidence: 70
needs review Optimizes repacking by skipping it when the project is unchanged, using craft-application mediation API. Approved by 1 reviewer with 1 unresolved comment; most CI checks passing.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 36
Staleness: 5
Complexity: 35
Confidence: 70
needs review Optimization to skip repacking output artifact when project is unchanged, using craft-application mediation API. Has 1 approval, 1 unresolved review comment, and 1 failing CI check.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 30
Staleness: 10
Complexity: 40
Confidence: 70
needs review Uses craft-application mediation API to skip repacking when project is unchanged. Approved by 1 reviewer with passing CI.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 27
Staleness: 5
Complexity: 40
Confidence: 70
needs review PR adds conditional repacking using craft-application mediation API to skip repacking when project is unchanged. Under review with 1 requested change and 1 unresolved comment; CI has a failing lint check.
qwen/qwen3.6-35b-a3b
Impact: 60
Quick Win: 27
Staleness: 15
Complexity: 55
Confidence: 70
needs review PR uses craft-application mediation API to skip repacking when project is unchanged. Has 1 unresolved review comment under changes_requested status; CI passing.
qwen3.6-35b-a3b-mtp-q6
Impact: 50
Quick Win: 28
Staleness: 5
Complexity: 45
Confidence: 75
needs review PR uses craft-application mediation API to skip repacking unchanged projects. Has 2 unresolved review comments requesting changes; author has not yet addressed them.

Update history

Date Change
closed
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: rockcraft#1350 (confidence 80%)

    Issue to move Rockcraft to the craft-application mediation framework; closed after ROCKCRAFT-319 was filed and partially addressed by this PR.

Related issues

Issue Project State Summary Similarity
#1350 Move Rockcraft to the craft-application mediation framework rockcraft closed Closed after ROCKCRAFT-319 was filed; no PR linked. Related commit 0b6ba8bd (PR #1357, 'skip repacking if project is unchanged') implements the no-repack goal.
85%
#444 feat: skip repack if project files are unchanged imagecraft merged PR #444 merged: adopts craft-application's metadata mediation API so imagecraft skips repacking when project files are unchanged (+788/-57, 9 files). Implements issue #442; an AI reviewer's managed-mode blocker was retracted.
82%
#442 Skip repacking when project files are not changed imagecraft open Maintainer request to adopt craft-application's package mediation API so imagecraft skips repacking unchanged projects; implementation merged in PR #444, but issue stays open/triaged pending the wider testing-workflow requirement.
81%
#2890 feat: skip repacking if project is not changed charmcraft merged Merged PR implementing metadata mediation for config.yaml and actions.yaml so charmcraft skips repacking unchanged projects; fixes #2858 and canonical/craft-application#821.
80%
#57 feat(rockcraft): support --ignore=unmaintained craft-actions merged PR #57 (commit 9f9af04) merged, adding an `ignore` input to rockcraft/rockcraft-pack that passes --ignore=<value> to rockcraft pack, closing feature issue #52. Approved by 3 reviewers with all CI checks green.
71%
#316 Rebase "rockcraft pack" onto craft-application framework rockcraft closed Rebased rockcraft pack onto craft-application in PR #354 (8d74e452); PR #395 later merged feature/craft-application into main, completing the migration to craft-application 1.0.0.
71%
#6325 Skip repacking if artifact contents are unchanged snapcraft open Conditional repacking is implemented through craft-application PR #1111, integrated and documented in Snapcraft 9.1, but this issue remains open.
71%
#354 refactor: use craft-application for "pack" rockcraft merged Merged #354 routed rockcraft pack through the CraftApplication runner (commit 8d74e452); its feature branch was later integrated into main by #395.
70%