style: adjust linting rules for ruff 0.12
Metadata
Current evaluation
Merged into main as 186cb0fb, updating Ruff 0.12 settings to ignore PLC0415 and avoid unnecessary noqa comments.
Resolution: closed resolved
Reason: PR #907 was approved and merged as commit 186cb0fb, adding PLC0415 to the Ruff ignore list because Rockcraft commonly uses function-level imports.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Rockcraft uses PLC0415 frequently enough that it doesn't make sense to noqa it.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into main as 186cb0fb, updating Ruff 0.12 settings to ignore PLC0415 and avoid unnecessary noqa comments. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #907 (commit 186cb0fb), updating Ruff 0.12 lint settings to permit PLC0415 because Rockcraft uses it frequently enough not to require noqa comments. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged adjustments to Ruff 0.12 linting rules, removing the noqa directive for PLC0415 since it is frequently used in Rockcraft. Approved by two reviewers, passed CI checks, and updated one file with three added lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged adjustments to ruff 0.12 linting rules. Removed noqa directives for the PLC0415 rule since Rockcraft uses it frequently enough to keep it enabled. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #408 style: fix linting for ruff 0.12 | starbase | merged | Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12. | |
| #1737 style: fix linting for ruff 0.5 | charmcraft | merged | Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5. | |
| #173 style: fix lint for ruff 0.12 | craft-archives | merged | Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed. | |
| #4981 style(lint): fix ruff 0.6 linting errors | snapcraft | merged | Merged PR #4981 as commit 3a1b8a949, fixing Ruff 0.6 lint errors with a minimal one-file change. | |
| #803 style: fix linting issues with ruff 0.12 | craft-application | merged | Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804. | |
| #319 style: update linting configuration for ruff 0.9 | starbase | merged | Ruff 0.9 lint configuration update merged into main via commit 45ab05b (PR #319). The unrelated git_describe_command suggestion was deferred to PR #321. | |
| #1577 style(lint): enable some previously-ignored ruff rules | charmcraft | merged | Merged PR #1577 in commit 1b650062, enabling previously ignored Ruff rules and applying related lint/style changes across 10 files. | |
| #1156 style: fix linting errors for ruff 0.12.0 | craft-parts | merged | Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed. | |
| #357 style: fix lints from ruff 0.12 | craft-cli | merged | Merged as dd635c9, fixing new Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed. | |
| #624 style(lint): fix ruff 0.6.0 linting errors | craft-providers | merged | Merged as commit 823622d, fixing Ruff 0.6.0 lint errors and switching the pre-commit Ruff hook to rolling versions. |