← Back to issue list

style: adjust linting rules for ruff 0.12

View original Github issue

Metadata

Project
rockcraft
Number
#907
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged adjustments to Ruff 0.12 linting rules, removing the noqa directive for PLC0415 since it is frequently used in Rockcraft. Approved by two reviewers, passed CI checks, and updated one file with three added lines.

Suggested action:

No scores available.

Issue body

Rockcraft uses PLC0415 frequently enough that it doesn't make sense to noqa it. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged adjustments to Ruff 0.12 linting rules, removing the noqa directive for PLC0415 since it is frequently used in Rockcraft. Approved by two reviewers, passed CI checks, and updated one file with three added lines.
qwen3.6-35b-a3b-mtp-q6 Merged adjustments to ruff 0.12 linting rules. Removed noqa directives for the PLC0415 rule since Rockcraft uses it frequently enough to keep it enabled.
qwen3.6-35b-a3b-mtp-q6 Merged adjustments to linting rules for ruff 0.12. Removed noqa directives for PLC0415 since Rockcraft frequently uses this rule, making suppression unnecessary.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Merged after receiving approval from two reviewers and passing all CI checks. The update resolves linting errors introduced by ruff 0.12.0 across five files, adjusting code formatting to comply with the new linter version.
85%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
85%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged after approval by two reviewers and passing CI. The change updates the codebase to comply with ruff 0.5 linting rules, adjusting style configurations and fixing formatting across one file.
84%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged following two approvals and passing CI checks. Resolves lint compatibility for ruff 0.12 while preserving backwards compatibility with ruff 0.11. Applied via a minimal two-line adjustment.
84%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.
84%
#55 lint: stricter ruff rules starbase merged Merged stricter ruff linting rules. The change modifies one file with 23 additions and 9 deletions, enforces stricter configuration, and received reviewer approval before integration.
83%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged following two reviewer approvals and passing CI. The change resolves ruff 0.6.0 linting errors across 31 files using ruff's autofix, resulting in 70 additions and 71 deletions.
83%
#165 style: fix linting for ruff 0.12 imagecraft merged Merged a pre-emptive linting update for ruff 0.12 compatibility. Approved by two reviewers and passed CI. The change adjusts formatting across four files to prevent breaking changes when the snap reaches stable.
83%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
83%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file.
83%