← Back to issue list

feat: package component hooks for core22

View original Github issue

Metadata

Project
snapcraft
Number
#4722
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4722 as commit 9a5dbfa69, enabling component-hook packaging for core22 with the implementation from #4717.

Resolution: closed resolved

Reason: The approved PR was merged into main as commit 9a5dbfa69. It enabled core22 component-hook packaging by reusing the core24 implementation delivered in PR #4717.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Package component hooks for core22. The code was already completed via #4717, it just needed to be enabled.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4722 as commit 9a5dbfa69, enabling component-hook packaging for core22 with the implementation from #4717.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#4722 (commit 9a5dbfa69), enabling component-hook packaging for core22 with the implementation delivered by #4717.
stealth/space-bunny-alpha — closed resolved Merged PR #4722 in commit 9a5dbfa69, enabling component-hook packaging for core22 using the implementation from #4717.
qwen/qwen3.6-35b-a3b — — Merged to enable packaging of component hooks for core22. Implementation was completed in #4717; this change activates the feature. Approved by two reviewers, passed CI, and modified four files.
qwen3.6-35b-a3b-mtp-q6 — — Merged activation of component hook packaging for core22. Implementation was completed in #4717; this change simply enabled the feature after passing lint and test checks.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4717 (confidence 100%)

    Merged as commit aafbe672b; provided the component-hook implementation that PR #4722 enabled for core22.

Related issues

Issue Project State Summary Similarity
#4717 feat: package component hooks for core24 snapcraft merged Merged PR #4717 as commit aafbe672b, adding core24 component-hook packaging and test coverage for CRAFT-2540.
87%
#4570 Support component hooks snapcraft closed Component hooks were implemented by merged PRs #4703, #4717 and #4722, adding hook metadata and core24/core22 packaging support.
81%
#4703 feat: add component metadata for hooks snapcraft merged Merged PR #4703 (commit aa49b3b72, CRAFT-2463) adding component hook metadata: project definition plus output into the component's meta/component.yaml. Built on merged #4701; follow-ups #4717/#4722 added core24/core22 component hook packaging, closing #4570.
80%