← Back to issue list

feat: add component metadata for hooks

View original Github issue

Metadata

Project
snapcraft
Number
#4703
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4703 (commit aa49b3b72, CRAFT-2463) adding component hook metadata: project definition plus output into the component's meta/component.yaml. Built on merged #4701; follow-ups #4717/#4722 added core24/core22 component hook packaging, closing #4570.

Resolution: closed resolved

Reason: The PR was approved and merged into main as commit aa49b3b72 ('feat: add component metadata for hooks (#4703)'), which explicitly states it fixes #4570. Related packaging support for component hooks landed afterwards in #4717 (aafbe672b, core24) and #4722 (9a5dbfa69, core22), closing issue #4570.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Support metadata for component hooks. This includes the project definition and the output in the component's `meta/component.yaml` file. Built on #4701, so only the last 3 commits are relevant. Fixes #4570 (CRAFT-2463)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4703 (commit aa49b3b72, CRAFT-2463) adding component hook metadata: project definition plus output into the component's meta/component.yaml. Built on merged #4701; follow-ups #4717/#4722 added core24/core22 component hook packaging, closing #4570.
stealth/space-bunny-alpha — closed resolved Merged PR #4703 as commit aa49b3b72, adding component hook metadata output to meta/component.yaml. Fixes #4570 (CRAFT-2463); follow-ups #4717 and #4722 added core24/core22 packaging.
stealth/space-bunny-alpha — closed resolved Merged PR #4703, adding component hook metadata to meta/component.yaml; commit aa49b3b72 resolves #4570.
stealth/space-bunny-alpha — closed resolved Merged PR #4703, adding component hook metadata and project output to meta/component.yaml; fixes #4570.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI checks. Adds project definition and output for component hooks in meta/component.yaml, resolving issue #4570. Built on PR #4701 and rebased to main.
qwen3.6-35b-a3b-mtp-q6 — — Merged after PR #4701 landed. Adds component metadata for hooks and updates meta/component.yaml output. Fixes #4570. Target branch switched to main, with integration test failures deferred until external review tools update.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4701 (confidence 95%)

    PR #4703 was explicitly built on #4701 (upload snaps with components, merged as 686b4e308); the author waited for #4701 to land before merging.

  • Likely Fixed By: canonical/snapcraft#4570 (confidence 95%)

    Issue #4570 'Support component hooks' was fixed by #4703 plus #4717 and #4722 (core24/core22 packaging), and is now closed.

  • Related To: canonical/snapcraft#4717 (confidence 88%)

    Follow-up PR (commit aafbe672b) packaging component hooks for core24, completing the #4570 feature after the metadata landed.

  • Related To: canonical/snapcraft#4722 (confidence 85%)

    Follow-up PR (commit 9a5dbfa69) enabling the same component hook packaging for core22.

Related issues

Issue Project State Summary Similarity
#4717 feat: package component hooks for core24 snapcraft merged Merged PR #4717 as commit aafbe672b, adding core24 component-hook packaging and test coverage for CRAFT-2540.
80%
#4722 feat: package component hooks for core22 snapcraft merged Merged PR #4722 as commit 9a5dbfa69, enabling component-hook packaging for core22 with the implementation from #4717.
80%
#4570 Support component hooks snapcraft closed Component hooks were implemented by merged PRs #4703, #4717 and #4722, adding hook metadata and core24/core22 packaging support.
78%
#6355 feat: mediate creation of component.yaml snapcraft merged PR #6355 by cmatsuoka merged, moving component.yaml generation to craft-application metadata mediation so each component artifact gets its metadata; closes issue #6360 (CRAFT-1376).
72%
#6379 feat: mediate creation of hooks and gui assets snapcraft merged Merged #6379, adding Craft Application metadata mediation when copying hooks and GUI assets into snap artifacts.
71%
#4503 feat(meta): generate metadata for components snapcraft merged Merged PR #4503 added component metadata generation at prime/component/<name>/meta/component.yaml, resolving issue #4466 (CRAFT-2312).
70%